Closed Bug 488390 Opened 15 years ago Closed 15 years ago

"ASSERTION: Shouldn't hit this case -- we should a be a combobox if we have no size set and no multiple set!" with RLO, <tr>

Categories

(Core :: Layout: Form Controls, defect, P2)

Product:
Core
Component:
Layout: Form Controls
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(4 keywords)

Attachments

(2 files)

testcase
525 bytes, application/xhtml+xml
Details
Fix
3.66 KB, patch
roc
: review+
roc
: superreview+
beltzner
: approval1.9.1+
dveditz
: approval1.9.0.11+
Details | Diff | Splinter Review
Attached file testcase — 
###!!! ASSERTION: Shouldn't hit this case -- we should a be a combobox if we have no size set and no multiple set!: 'Not Reached', file /Users/jruderman/central/layout/forms/nsListControlFrame.cpp, line 1913

This assertion also appeared in bug 366205, which had a patch attached but ended up WFM.
Attached patch Fix — — Splinter Review 
The issue is that we fail to find the primary frame for the <span> that we need to reframe to reframe the <select> because the code that walks continuations and special siblings doesn't do the latter correctly.

I'm not sure why the reftest doesn't fail in Fx3, but I think we want this fix on both branches....
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #372769 - Flags: superreview?(roc)
Attachment #372769 - Flags: review?(roc)
Just to make it clear, not reframing things when we need to, or not removing frames from the document when the node is removed, can be really bad...  Certainly virtual function call on null bad, possibly worse.
Flags: blocking1.9.1?
Flags: blocking1.9.0.10?
Attachment #372769 - Flags: superreview?(roc)
Attachment #372769 - Flags: superreview+
Attachment #372769 - Flags: review?(roc)
Attachment #372769 - Flags: review+
Attachment #372769 - Flags: approval1.9.1?
Attachment #372769 - Flags: approval1.9.0.10?
Pushed http://hg.mozilla.org/mozilla-central/rev/3c9468b1b453
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment on attachment 372769 [details] [diff] [review]
Fix

a191=beltzner
Attachment #372769 - Flags: approval1.9.1? → approval1.9.1+
Flags: blocking1.9.0.10? → wanted1.9.0.x+
Comment on attachment 372769 [details] [diff] [review]
Fix

approved for 1.9.0.10, a=dveditz for release-drivers
Attachment #372769 - Flags: approval1.9.0.10? → approval1.9.0.10+
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Fixed in CVS.
Keywords: fixed1.9.0.10
Verified fixed for 1.9.0.11 using my debug build (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.11pre) Gecko/2009051111 GranParadiso/3.0.11pre).
Keywords: fixed1.9.0.11 → verified1.9.0.11
verified FIXED (no assertions) on debug builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090608 Shiretoko/3.5pre ID:20090608122057

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090608 Minefield/3.6a1pre ID:20090608122028
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: