Closed Bug 488410 Opened 13 years ago Closed 13 years ago

autocomplete popup should display more than 7 entries, and should be pannable

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch (obsolete) — Splinter Review
I set a limit of 20 entries, but that is arbitrary. Currently doesn't work so great because mousing up after a pan still registers as a click, will need to sort things out with InputManager to fix that.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Comment on attachment 372762 [details] [diff] [review]
patch

Is there a downside to using richlistbox instead of scrollbox? We were hoping to create a "master" set of CSS styles for richlistboxes/items. Of course CSS is flexible enough to let us apply them here too.
richlistbox is just a lot heavier implementation wise (and requires a bunch of unnecessary richlistitem children, IIRC). I think we can probably manage to make our richlistbox styles work with this specific case of labels in a scrollbox fairly easily.
Attached patch updated patchSplinter Review
Attachment #372762 - Attachment is obsolete: true
Attachment #375227 - Flags: review?(mark.finkle)
Attachment #375227 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mobile-browser/rev/20755fda5c49
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.