488446 - Disallow localStorage data manipulation in PB and session-only mode, follow up to bug 486654

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Honza Bambas (:mayhemer)]

(In reply to bug 486654 comment #18)
> (In reply to bug 486654 comment #15)
> > What I suggest now after I completely went through the Brady's thread is to
> > throw a DOM_SECURITY_ERROR when accessing window.localStorage object while in
> > either private-browsing-mode or session-only-cookies-mode. The letter is
> > already implemented.
> 
> A brain-dead way to break this would be:
> 
> var storage = window.localStorage;
> // use |storage| from this point forward
> 
> Any web page which does that will not be affected by the user changing their
> cookie settings, unless it's reloaded.

Based on these comments make sure to throw the same security error when accessing dom storage data (getItem, setItem) while in either private-browsing-mode or session-only-cookies-mode.

This is just a followup to have a complete 20/80 solution before we fix bug 487695.

Should be b191+ if we don't get fix bug 487695.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: wip 1

mSessionOnly member of nsDOMStorage is set when cookies are in session-only
mode OR we are PB mode. I added this condition to nsDOMStorage::CanUseStorage.
Then, when checking access to localStorage (only localStorage) with setItem or
getItem we throw a security error when being session only (addresses this bug).

Confirmed by a test.

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 373138 [details] [diff] [review]
wip 1

Sorry to rise r? so late...

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #0)
> Should be b191+ if we don't get fix bug 487695.

Bug 487695 is blocking, so this one isn't per this logic!

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 373138 [details] [diff] [review]
wip 1

We have a correct patch for this issue in bug 487695. No need to review this.

Comment 5

[Daniel Veditz [:dveditz]]

So this bug is WONTFIX?

Comment 6

[Honza Bambas (:mayhemer)]

After bug 487695 gets fixed, we probably can. This was intended as a quick workaround.

Comment 7

[Honza Bambas (:mayhemer)]

Bug 487695 has just landed.