Closed Bug 488454 Opened 11 years ago Closed 10 years ago

new icons for compose window toolbar for aero

Categories

(Thunderbird :: Message Compose Window, enhancement)

x86
Windows Vista
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: andreasn, Assigned: clarkbw)

References

Details

(Whiteboard: [no l10n impact])

Attachments

(5 files, 2 obsolete files)

Bug for tracking new icons for the compose window.
Attached image toolbar icons, big size
Blocks: 488060
Severity: normal → enhancement
Flags: blocking-thunderbird3+
Target Milestone: --- → Thunderbird 3.0rc1
Whiteboard: [needs patch]
we could probably wait on getting a format-buttons image for aero or drop this in now.
Assignee: nobody → clarkbw
Status: NEW → ASSIGNED
Whiteboard: [needs patch] → [has patch][needs review or new icon]
Here are the format icons. Using a more flat style on these, similar to what Windows Photo Gallery uses (and Firefox use for the navigation icons). This also don't show any icons for the sub items in the insert menu (similar to what other vista menus does).
Attachment #392685 - Flags: ui-review?(clarkbw)
Comment on attachment 392685 [details] [diff] [review]
format icons and css as patch on trunk

Looks good, I like the flat style.  I'd like to get philor to code review this as well.

There's enough difference between the two CSS files such that it seems reasonable to have two different ones for this.
Attachment #392685 - Flags: ui-review?(clarkbw)
Attachment #392685 - Flags: ui-review+
Attachment #392685 - Flags: review?(philringnalda)
Call me picky, but I don't really like seeing a comment like "/* Lets see if this does something*/" - especially if it's for the prefs window, in a patch about the compose toolbar :)
Eeek, did I leave that in there?
Terribly sorry for that, will fix a new patch.
Attached patch updated patchSplinter Review
hope this works better. The other part that snuck in was from trying to fix #504042, but it turned out to be fixable from another place.
Comment on attachment 393540 [details] [diff] [review]
updated patch

thx - I probably could've removed it myself, but I figured you would be more likely than me to notice any other stray bits.
Attachment #393540 - Flags: review?(philringnalda)
Attachment #392685 - Attachment is obsolete: true
Attachment #392685 - Flags: review?(philringnalda)
Attachment #381109 - Attachment is obsolete: true
Comment on attachment 393540 [details] [diff] [review]
updated patch

Looks fine, other than all the trailing spaces and weird choices of blank-lines-or-not which came from the original - I think I fixed at least most of them before I pushed it.
Attachment #393540 - Flags: review?(philringnalda) → review+
http://hg.mozilla.org/comm-central/rev/5258a692afbc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Summary: new icons for compose window toolbar → new icons for compose window toolbar for aero
Whiteboard: [has patch][needs review or new icon]
Target Milestone: Thunderbird 3.0rc1 → Thunderbird 3.0b4
Realized the toolbar images wasn't included in this patch, and hence not checked in. Patch for that coming up.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Here are the toolbar icons.
Attachment #401185 - Flags: ui-review?(clarkbw)
Attachment #401185 - Flags: review?(philringnalda)
Whiteboard: [no l10n impact]
Target Milestone: Thunderbird 3.0b4 → Thunderbird 3.0rc1
Attachment #401185 - Flags: review?(philringnalda) → review+
Comment on attachment 401185 [details] [diff] [review]
toolbar icons as patch

having problems with my build so I'll just plus this blindly and blame andreas for any issues later on :-P
Attachment #401185 - Flags: ui-review?(clarkbw) → ui-review+
Attachment #401185 - Flags: approval-thunderbird3?
Attachment #401185 - Flags: approval-thunderbird3? → approval-thunderbird3+
(In reply to comment #15)
> (From update of attachment 401185 [details] [diff] [review])
> having problems with my build so I'll just plus this blindly and blame andreas
> for any issues later on :-P

Crap :)
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/386c078a3626
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.