488454 - new icons for compose window toolbar for aero

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, enhancement)

Description

[Andreas Nilsson (:andreasn)]

Bug for tracking new icons for the compose window.

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: toolbar icons, big size

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: toolbar icons, small size

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: adds the aero compose toolbar images

we could probably wait on getting a format-buttons image for aero or drop this in now.

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: format icons and css as patch on trunk

Here are the format icons. Using a more flat style on these, similar to what Windows Photo Gallery uses (and Firefox use for the navigation icons). This also don't show any icons for the sub items in the insert menu (similar to what other vista menus does).

Comment 5

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of the patch in action

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 392685 [details] [diff] [review]
format icons and css as patch on trunk

Looks good, I like the flat style.  I'd like to get philor to code review this as well.

There's enough difference between the two CSS files such that it seems reasonable to have two different ones for this.

Comment 7

[Phil Ringnalda (:philor)]

Call me picky, but I don't really like seeing a comment like "/* Lets see if this does something*/" - especially if it's for the prefs window, in a patch about the compose toolbar :)

Comment 8

[Andreas Nilsson (:andreasn)]

Eeek, did I leave that in there?
Terribly sorry for that, will fix a new patch.

Comment 9

[Andreas Nilsson (:andreasn)]

Attachment: updated patch

hope this works better. The other part that snuck in was from trying to fix #504042, but it turned out to be fixable from another place.

Comment 10

[Phil Ringnalda (:philor)]

Comment on attachment 393540 [details] [diff] [review]
updated patch

thx - I probably could've removed it myself, but I figured you would be more likely than me to notice any other stray bits.

Comment 11

[Phil Ringnalda (:philor)]

Comment on attachment 393540 [details] [diff] [review]
updated patch

Looks fine, other than all the trailing spaces and weird choices of blank-lines-or-not which came from the original - I think I fixed at least most of them before I pushed it.

Comment 12

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/5258a692afbc

Comment 13

[Andreas Nilsson (:andreasn)]

Realized the toolbar images wasn't included in this patch, and hence not checked in. Patch for that coming up.

Comment 14

[Andreas Nilsson (:andreasn)]

Attachment: toolbar icons as patch

Here are the toolbar icons.

Comment 15

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 401185 [details] [diff] [review]
toolbar icons as patch

having problems with my build so I'll just plus this blindly and blame andreas for any issues later on :-P

Comment 16

[Andreas Nilsson (:andreasn)]

(In reply to comment #15)
> (From update of attachment 401185 [details] [diff] [review])
> having problems with my build so I'll just plus this blindly and blame andreas
> for any issues later on :-P

Crap :)

Comment 17

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/386c078a3626