488460 - Invalidation cleanup

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

I've been spending a whole lot of time in the invalidation code recently, and found that some function names are rather poor, and the code is unclear and under-documented in many places. This bug covers a bunch of cleanup patches I want to land.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch 1

Here's some stuff I separated from the patch in bug 463939.

Comment 2

[Robert Longson [:longsonr]]

+  // XXX [perf] here we call UpdateCoveredRegion on all our children, not just
+  // the active child. Maybe we should optimize for that? Or should
+  // getBoundingClientRect() always return something sane for *all* children?

Oops, we should just update the active child covered region (and perhaps the previously active child covered region).

Comment 3

[Jonathan Watt [:jwatt]]

I'm not sure. I filed bug 495968 for that part.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 381096 [details] [diff] [review]
patch

>+  // Areas dirtied by changes to decendents that are in our document

s/descendent/descendant/

r=longsonr with nit picked.

Comment 6

[Jonathan Watt [:jwatt]]

Pushed http://hg.mozilla.org/mozilla-central/rev/ddcc8721c954