qcms build break with pre-4 GCCs

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: mozilla, Assigned: mozilla)

Tracking

({fixed1.9.1})

Trunk
All
OS/2
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.34 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review
Posted patch fix (obsolete) — Splinter Review
There is an #if 0 -- #endif block in qcms/qcmsint.h that breaks the build on GCC 3.3 with a "missing terminating ' character" warning. The trivial fix is to C- or C++-style comment the #if0-commented comment... (Or maybe that block can now be fully removed.)
Attachment #372850 - Flags: review?(jmuizelaar)
Posted patch fix v2Splinter Review
There is another one of those in nsJPEGDecoder...
Attachment #372850 - Attachment is obsolete: true
Attachment #372851 - Flags: review?(jmuizelaar)
Attachment #372850 - Flags: review?(jmuizelaar)
Jeff, should I ask somebody else for review -- or even check in as build-break fix unreviewed (as this only touches commented code)?
When asking someone a question one should also CC him...
Attachment #372851 - Flags: review?(jmuizelaar) → review+
Comment on attachment 372851 [details] [diff] [review]
fix v2

I'd prefer the comment text to start on the same line as the comment. e.g.
/* this is from ...

Other than that this looks fine.
Pushed with that change to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/f083055d319a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
And to mozilla-1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f7511a03371b
Keywords: fixed1.9.1
Version: 1.9.1 Branch → Trunk
Assignee: nobody → mozilla
You need to log in before you can comment on or make changes to this bug.