488473 - mozilla.widget.disable-native-theme set to true visually breaks menus on Windows (padding, marker)

Status: RESOLVED INVALID

(Core :: XUL, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Visually broken menu

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090414 Shiretoko/3.5b4pre (.NET CLR 3.5.30729) ID:20090414044032

With the patch on bug 474825 and mozilla.widget.disable-native-theme set to true the menu on Windows gets visually broken. Here the issues I can see:

* White text and no background color for selected entries in the main menu
* Markers for sub-menus are not visible
* Wrong paddings between menu items

See the attached screenshot.

Steps:
1. Create a fresh profile
2. Add the hidden pref mozilla.widget.disable-native-theme and set it to true
3. Restart Firefox

Comment 1

[Doug Turner (:dougt)]

this pref isn't suppose to be true on Firefox.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Out of curiosity for which product or for what is it used at all? It's not really clear from bug 474825.

Comment 3

[Doug Turner (:dougt)]

hey henrik,
it is for Fennec.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Doug. As what I can see its WinCE specific. No idea why this hidden pref was added in my profile. I cannot remember.