488513 - Update breakpad for Socorro support

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

There's a review in flight for Breakpad.framework to have built-in Socorro support, doing key remapping, adding required keys like crash time, etc. Once that lands, I need to rev our copy of breakpad and remove some of our main.m hackery.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

So, other than seeing if *something* gets submitted, it's not worthwhile doing any testing on what we have yet?

Comment 2

[Stuart Morgan]

This change will actually be pretty minor; more data on the server (including comments) and fewer lines of code in the setup.

On the other hand, since the UI is changing, the submission is changing a bit, and we don't have symbols yet, it's probably accurate to say that there's not much to test yet. Mostly that UI comes up when there's a crash, I guess, and that a crash dump is written to disk (~/Library/Breakpad/Camino).

Comment 3

[Stuart Morgan]

Attachment: camino changes

Once http://breakpad.appspot.com/9001/show has landed upstream I'll rev our copy again. I'll need to land these changes at the same time to avoid making things more broken. Once this lands we'll have real uptime and crash time values. We would theoretically have comments (the "socorro" entry maps that along with everything else), but it turns out that comments are broken in breakpad itself right now, so we'll instead get those for free in some later update.

Since the next pull will get my upstream changes for UI timeout control (bug 488727) and that also involves a new plist entry, I'm including that fix here as well.

Comment 4

[Stuart Morgan]

(comments will be fixed with http://breakpad.appspot.com/9001/show)

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 374150 [details] [diff] [review]
camino changes

u can has sr=pink

Comment 6

[Stuart Morgan]

Landed, along with an update to r335 of Breakpad. That include the comment fix, so all data we are collecting should now be correct.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)

> Once http://breakpad.appspot.com/9001/show has landed upstream I'll rev our
> copy again. I'll need to land these changes at the same time to avoid making
> Once this lands we'll have real uptime and crash time values.

We don't seem to have "Last Crash" fields in our reports, just uptime (or did you mean something else by "crash time"?); see, for instance, bp-51f4a017-2a2d-4958-84b0-570292090508 vs. bp-e75c7261-c9e7-490d-9882-1eb7c2090504

Comment 8

[Stuart Morgan]

Crash time is the actual time when we crashed; Breakpad doesn't support Last Crash. I'll add it to my list of nice-to-have's (it's an optional field for Socorro, and it didn't seem as important, so I didn't worry about it for this bug). It's probably easy to add given the throttling code.