Status

()

defect
--
minor
RESOLVED FIXED
10 years ago
4 months ago

People

(Reporter: mrbkap, Assigned: peterv)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch Patch (obsolete) — Splinter Review
Currently, the generated code for nsIDOMNodeList_Item_tn reads:
    PRUint32 _arg0 = (PRUint32) arg0;
    nsINode* result = self->GetNodeAt(arg0);
#ifdef DEBUG
    nsresult debug_rv;
    nsCOMPtr<nsIDOMNodeList> debug_self = do_QueryInterface(self);
    nsCOMPtr<nsIDOMNode> debug_result;
    debug_rv = debug_self->Item(_arg0, getter_AddRefs(debug_result));
    NS_ASSERTION(NS_SUCCEEDED(debug_rv) && xpc_qsSameResult(debug_result, result),
                 "Got the wrong answer from the custom method call!");

note that we call self->GetNodeAt with parameter arg0 instead of _arg0. In practice, this doesn't matter, but it causes a warning and is bad hygiene.
Attachment #372958 - Flags: superreview?(jst)
Attachment #372958 - Flags: review?(jst)
Attachment #372958 - Flags: superreview?(jst)
Attachment #372958 - Flags: superreview+
Attachment #372958 - Flags: review?(jst)
Attachment #372958 - Flags: review+
...except that the non-fast version of the function _needs_ arg0 (no underscore). So I'll just let this be.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Attachment #372958 - Attachment is obsolete: true
Attachment #372958 - Flags: superreview+
Attachment #372958 - Flags: review+
We should still fix this, I'll attach the patch that I discussed with bent at some point.
Assignee: mrbkap → peterv
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Posted patch v1Splinter Review
Attachment #373665 - Flags: superreview?(mrbkap)
Attachment #373665 - Flags: review?(bent.mozilla)
Attachment #373665 - Flags: review?(bent.mozilla) → review+
Attachment #373665 - Flags: superreview?(mrbkap) → superreview+
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.