User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3) Gecko/20090412 Gentoo Shiretoko/3.1b3 Build Identifier: extracted from #485802 patch set Reproducible: Always Actual Results: if guid wasn't set while creating add-on user can complete/nominate add-on w/o guid. Expected Results: do not let user complete/nominate add-on w/o guid
Created attachment 373044 [details] [diff] [review] Do not let user save empty GUID
1. I would add tests for the empty guid case 2. The `switch ($efield)` should just be `if ($efield == 'guid')` since the error you're printing is `invalid_guid`.
Aleksey, any updates on this bug? Do you have time for this?
GUIDs are checked for validity during the upload process.