488626 - FT font support needs to get correct family names out

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Our FT2 font backend seems to grab the base family name from ttf files; this is coming out as lowercase ("tahoma", "times new roman") and generally looks odd.  I'm guessing that we need to dig into the full name tables to get the real name out, not sure what the best way is to do that.

Comment 1

[John Daggett (:jtd)]

gfxFontUtils contains code for reading the name table.  Just use a FT2 API to read the name table data into memory.  To match other platforms, localized font family names should match indpendent of underlying locale.  For UI code, the family name should be the locale-specific name or the default name (i.e. English or the first name in the name table) when a locale-specific name doesn't exist.

Comment 3

[Takuro Ashie [:ashie]]

Attachment: A sample patch to obtain font family names

Because I didn't notice this bug, I was working on it in another way.
I reattach the patch here for reference.

Comment 4

[Takuro Ashie [:ashie]]

Attachment: Patch v2

I've fixed previous patch to use gfxFontUtils::ReadNames instead of using FT_Get_Sfnt_Name.
I fixed also gfxFontUtils.cpp because it causes alignment error on ARM arch.

Comment 5

[John Daggett (:jtd)]

(In reply to comment #4)
> I've fixed previous patch to use gfxFontUtils::ReadNames instead of using
> FT_Get_Sfnt_Name.
> I fixed also gfxFontUtils.cpp because it causes alignment error on ARM arch.

Yeah, I was going to mention that but you beat me to it.  One note, it looks like you're merging in fullnames and postscript names as ways of matching a family, this isn't correct.  The font-family property should only match the family data.  Name matching of other data in Safari (postscript) and IE (fullname) are bugs, er, unintended consequences of using platform API's?!? ;)  

Face names and family names need to be distinct, otherwise you end up with CSS that doesn't make sense:

body {
  font-family: "Arial Bold";
  font-weight: normal;
}

Which face should this match?  Normal?  Bold?

Comment 6

[Takuro Ashie [:ashie]]

Attachment: Patch v3

Thank you for pointing out it.
To tell the truth, I couldn't decide that full names and PS names should
be merged or not because some APIs and programs doesn't distinguish them.

Comment 7

[Takuro Ashie [:ashie]]

This bug seems related with bug 493280.
If it's wrong, please remove dependency.

Comment 8

[Takuro Ashie [:ashie]]

Attachment: Patch v4

Follow trunk.

I think more work is needed for this patch because Qt and Gtk(with gfxFT2Fonts) platform has same issue.

Comment 9

[Takuro Ashie [:ashie]]

Now I turn over the dependency because it can be fixed using gfxPlatformFontList which is introduced at bug 493280.

Comment 10

[Takuro Ashie [:ashie]]

Attachment: Patch v5

Follow trunk, and resolve standard family name also on GTK and Qt.

Comment 12

[Ed Morley [:emorley]]

WinCE/Windows Mobile support has been removed from the main build system, Spidermonkey, mobile installer, in-app updater and so on (see bug 614720, bug 554087 and all their dependants). Until such point where MS decide to release a Windows Phone 7 NDK and the decision is made to port to that platform, this is WONTFIX.

Filter bugmail on WinCEMassWONTFIX.