Closed
Bug 488639
Opened 15 years ago
Closed 15 years ago
SPARC jit: testIntOverflow, testIntUnderflow failed
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1
People
(Reporter: ginnchen+exoracle, Assigned: leon.sha)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
1.60 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
./js -j trace-test.js FAILED: testIntOverflow, testIntUnderflow ./js trace-test.js All passed.
These 2 tests were passed, if I use mozilla-1.9.1 js binary with mozilla 1.9.1 branch trace-test.js. But they're failed, if I use mozilla-1.9.1 js binary with mozilla-central trace-test.js.
The ADD and SUB in asm_arith should modify the condition codes.
Attachment #373804 -
Flags: review?(gal)
|
||
Comment 3•15 years ago
|
||
Is it possible to have mul set the cc as well?
|
|
||
Updated•15 years ago
|
Attachment #373804 -
Flags: review?(gal) → review+
I searched the sparc menu, there do have some mul instructions, but they are all deprecated. The recommended mul instruction do not modify any condition codes. I don't know why.
|
||
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6684da21fb12
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Pushed into 1.9.1 branch as NPOTB changes. http://hg.mozilla.org/releases/mozilla-1.9.1/rev/84d3c65a9680
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•