Closed
Bug 488675
Opened 15 years ago
Closed 14 years ago
German clear history dialog with English string and narrow width
Categories
(Mozilla Localizations :: de / German, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Unassigned)
References
Details
(Keywords: fixed1.9.1)
Attachments
(2 files)
20.96 KB,
image/png
|
Details | |
1.04 KB,
patch
|
atopal
:
review+
|
Details | Diff | Splinter Review |
The clear history refresh bug 480169 exposed new strings in the German localization, one of which is English. The dialog size ain't pretty either. Screenshot attached. Not sure if we need to block B4 on this.
Reporter | ||
Comment 1•15 years ago
|
||
I copied and pasted the "clear all history" string from above, and bumped the dialog size to work, I have only tested this on linux, though. Kadir, want to have that in?
Attachment #373092 -
Flags: review?(a.topal)
Comment 2•15 years ago
|
||
Comment on attachment 373092 [details] [diff] [review] translate "all history will be cleared" and bump dialog size Thanks Axel! Can't test this right now on Mac or Windows, but it will be better than before anyway.
Attachment #373092 -
Flags: review?(a.topal) → review+
Reporter | ||
Comment 3•15 years ago
|
||
Wan't me to land that for you or are you going to land that yourself?
Reporter | ||
Comment 4•15 years ago
|
||
Landed on http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/de/rev/2ee80bc19875, going to leave the bug open for the landing on central, and possible further size adjustments. I'll update the opt-in rev to 2ee80bc19875, too.
Keywords: fixed1.9.1
Comment 5•15 years ago
|
||
35em are okay for Windows Vista. What for is the "_" before the dropdown list?
Reporter | ||
Comment 6•15 years ago
|
||
There's a prefix string, which is a " ", with an accesskey " ". Which is then underlined.
Comment 7•15 years ago
|
||
Axel, is it possible to drop the accesskey or would that be an accessability problem? We should maybe add an accesskey to the postfix string and let localizers decide which key they want to use.
Reporter | ||
Comment 8•15 years ago
|
||
<?xml version="1.0"?> <?xml-stylesheet href="chrome://global/skin/" type="text/css"?> <window id="yourwindow" xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"> <hbox> <label value="Prefix " accesskey="" control="choice"/> <menulist id="choice" flex="1"> <menupopup> <menuitem label="one of many"/> </menupopup> </menulist> <label value=" postfix" accesskey="x" control="choice"/> </hbox> </window> seems to do what you want. File a bug to add that and CC :l10n? Not sure if we can get this into 3.5 still, and even less sure how folks like narro or translate toolkit would cope with this. As if both have accesskeys, it looks crappy, too.
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•