488743 - Mozmill Cannot Automate Selection on a XUL menulist element

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect, P1)

Description

[cmtalbert]

Attachment: test demonstrating necessary workaround

<menulist> elements can be used to create a drop down selection list.  The code in Mozmill is currently written against <option> elements in HTML and does not work for <menulist> elements.  

We need a new set of controller functions to select items from <menulist> elements.

I'll attach a test where I have to simulate key commands in order to make the menulist item work.  That is the only work around, and it's not entirely clear that the work around is viable because sometimes the ending <enter> keypress event gets targeted elsewhere than the menulist, causing other behaviors in the system.

Comment 1

[cmtalbert]

We really really need this for 1.2.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Testcase with not working select function

Here the modified test which uses the not working select function.

Comment 3

[Mikeal Rogers [:mikeal] (mrogers@)]

I think we should just check the tagname on the element passed and ifdef this in the select API instead of writing a new API for menulist.

Comment 4

[Mikeal Rogers [:mikeal] (mrogers@)]

Looks like <menulist> works a bit differently than <options>, adam will have to take a deeper look at this.

https://developer.mozilla.org/en/XUL/menulist

Comment 5

[Adam Christian]

Committed revision 467.

This now works:

var mozmill = {}; Components.utils.import('resource://mozmill/modules/mozmill.js', mozmill);
var elementslib = {}; Components.utils.import('resource://mozmill/modules/elementslib.js', elementslib);

var setupModule = function(module) {
  module.controller = mozmill.getBrowserController();
}

var testPrivacyPanel = function(){
  // load pref pane
  prefcontroller = mozmill.getPreferencesController();

  // load the privacy panel
  prefcontroller.click(new elementslib.Lookup(prefcontroller.window.document, 
                       '/id("BrowserPreferences")/anon({"orient":"vertical"})/anon({"anonid":"selector"})/{"pane":"panePrivacy"}'));

  // Let the UI catch up to us
  //prefcontroller.sleep(400);
  prefcontroller.waitForElement(new elementslib.ID(prefcontroller.window.document, "locationBarSuggestion"));

  // twiddle the drop down
  histDropDown = new elementslib.ID(prefcontroller.window.document, "locationBarSuggestion");
  prefcontroller.select(histDropDown, null, "Bookmarks", null);
  
  prefcontroller.click(histDropDown);
  prefcontroller.keypress(histDropDown, 40, 0, {});
  prefcontroller.keypress(histDropDown, 40, 0, {});
  prefcontroller.keypress(histDropDown, 0, 13, {});
  controller.assertNode(new elementslib.ID(prefcontroller.window.document,
                        "rememberDownloads"));
  controller.assertNode(new elementslib.ID(prefcontroller.window.document,
                        "rememberForms"));
  controller.assertNode(new elementslib.ID(prefcontroller.window.document,
                        "acceptCookies"));
  controller.assertNode(new elementslib.ID(prefcontroller.window.document,
                        "alwaysClear"));
  controller.assertNode(new elementslib.ID(prefcontroller.window.document,
                        "clearDataSettings"));

}

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's not possible to select the first index or option due to a failure in the parameter checks. I'll attach a patch. Reopening.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Follow-up patch for index/option zero

Comment 8

[Adam Christian]

Comment on attachment 380648 [details] [diff] [review]
Follow-up patch for index/option zero

Looks good to me, will go ahead and apply this.

Comment 9

[Adam Christian]

Comment on attachment 380648 [details] [diff] [review]
Follow-up patch for index/option zero

Looks good to me, will go ahead and apply this.

Comment 10

[Adam Christian]

Committed revision 471.

Comment 11

[Adam Christian]

Believe this is now done, marking fixed.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, we have to reopen this bug for at least one more fix. We should not check for undefined as what I proposed in my last patch. We should do something like "if (indx >= 0)" for all those if constructs. Adam can you fix that?

Comment 13

[Mikeal Rogers [:mikeal] (mrogers@)]

Took Henrik's latest suggestion. Fixed.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Two checkins were needed because we also have to check value and option. Both landed with:

http://code.google.com/p/mozmill/source/detail?r=485
http://code.google.com/p/mozmill/source/detail?r=486

That should be fine now. Thanks Mikeal.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We checked in a further patch which doesn't use tagName anymore which depends on the given namespace. localName is the way we should go.

http://code.google.com/p/mozmill/source/detail?r=506

Further note that we cannot automate menulist elements when they are childrens of a panel element. See bug 443155.