488806 - network geolocation can spam server

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect, P2)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

if you reload a page over and over, we never remove our listener to the wifi scanner which results in many more updates than request.

basically, we should only call startWatching after we create the wifi_service.

Comment 1

[Doug Turner (:dougt)]

updating summary to be less scary.  it only is somewhat bad if you have a user hitting reload a dozens and dozens of times.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Not gonna block b4 on this, but we'd take it if it gets done in time.

Comment 3

[Doug Turner (:dougt)]

right, no need to block beta for this.

Comment 4

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/9e06217fc471

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 373267 [details] [diff] [review]
patch v.1

a191=beltzner

Comment 6

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/bbf17528cdd2