Closed
Bug 488807
Opened 17 years ago
Closed 17 years ago
Should close the handle of FindFirstFile.
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: hiro, Assigned: hiro)
Details
(Keywords: mobile)
Attachments
(1 file, 1 obsolete file)
|
1.22 KB,
patch
|
blassey
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
Should close the handle of FindFirstFile in mar_create.c.
Attachment #373271 -
Flags: review?(bugmail)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 373271 [details] [diff] [review]
Proposed patch
>
>+#ifdef WINCE
>+ CloseHandle(handle);
>+#endif
This should be FindClose instead of CloseHandle
other than that it looks good
Attachment #373271 -
Flags: review?(bugmail)
Attachment #373271 -
Flags: review?(benjamin)
Attachment #373271 -
Flags: review+
|
Assignee | |
Comment 2•17 years ago
|
||
Thanks Brad.
I noticed that previous patch has some problem.
This new one fixes these:
* Remove redundant ifdef WINCE
* Declare HANDLE value at the top of "if" block
* Use FindClose
Brad, could you please review this again?
Assignee: nobody → ikezoe
Attachment #373271 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #373772 -
Flags: superreview?(benjamin)
Attachment #373772 -
Flags: review?(bugmail)
Attachment #373271 -
Flags: review?(benjamin)
|
|
||
Updated•17 years ago
|
Attachment #373772 -
Flags: review?(bugmail) → review+
|
||
Updated•17 years ago
|
Attachment #373772 -
Flags: superreview?(benjamin) → superreview+
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
||
Comment 3•17 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•