488811 - nsIPermissionManager.removeAll() should delete DB and re-init rather than just bailing.

Status: RESOLVED FIXED

(Core :: Graphics: Image Blocking, defect)

Description

[Mike Connor [:mconnor]]

see bug 488801

If this fails for any reason we should just nuke the file and re-init the DB.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Delete the corrupted DB and reinit it instead of just failing.

I also added a unit test which deliberately corrupts permissions.sqlite and tries to make sure that nsIPermissionManager::RemoveAll does not fail.

Comment 2

[[e-mail]]

Comment on attachment 373280 [details] [diff] [review]
Patch (v1)

r=me, thanks!

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 373280 [details] [diff] [review]
Patch (v1)

Unless there are a lot of existing callers, please don't use an optional arg here.  Just change the callers as needed.

With that, sr=me.

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/2aecc6cf5b2a

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 373280 [details] [diff] [review]
Patch (v1)

a191=beltzner

Comment 6

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/491de8a3ded0