488824 - Remove WIN16 (support) code, in js/src

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Serge Gautherie (:sgautherie)]

Bug 438331 comment 28:
{{
From  Serge Gautherie (:sgautherie)   2009-04-12 01:48:30 PDT

{
/js/src/liveconnect/jsj_hash.c
    * line 133 -- #endif /* WIN16 */
    * line 230 -- #endif /* WIN16 */
}
will be removed by bug 442399.
}}

Comment 1

[Jonathan Steele]

Is this bug Fixed?

Comment 2

[Serge Gautherie (:sgautherie)]

No, 2 occurrences remain.

Comment 3

[Andreas Gal :gal]

Serge, want to submit a patch? I can review and land it.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) 2 config.mk [Checkin: Comment 5]

Fwiw, this was not (entirely) true (anymore) anyway, due to 'jpeg3250':
http://mxr.mozilla.org/mozilla-central/search?string=%5B%5E_S%5DVERSION_NUMBER&regexp=on&case=on

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 390685 [details] [diff] [review]
(Av1) 2 config.mk
[Checkin: Comment 5]


http://hg.mozilla.org/mozilla-central/rev/7accd82ab321

Comment 6

[Serge Gautherie (:sgautherie)]

Peter, could you look into jsOS240.def? (which is the last occurrence)

Comment 7

[Peter Weilbacher]

Serge, jsOS240.def is obsolete (and apparently has been for years, since when is there no jsOS240.dll any more?), it doesn't even list the symbols with the currently used calling convention. And I can very well compile js/src without it. Please just remove that file.

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Remove jsOS240.def [Checkin: Comment 9]

Per comment 7.

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 390757 [details] [diff] [review]
(Bv1) Remove jsOS240.def
[Checkin: Comment 9]


http://hg.mozilla.org/mozilla-central/rev/1f8bcac8854b