If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove WIN16 (support) code, in js/src

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Core
JavaScript Engine
--
trivial
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.9.2a1
x86
Windows 95
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

9 years ago
Bug 438331 comment 28:
{{
From  Serge Gautherie (:sgautherie)   2009-04-12 01:48:30 PDT

{
/js/src/liveconnect/jsj_hash.c
    * line 133 -- #endif /* WIN16 */
    * line 230 -- #endif /* WIN16 */
}
will be removed by bug 442399.
}}

Comment 1

8 years ago
Is this bug Fixed?
(Assignee)

Comment 2

8 years ago
No, 2 occurrences remain.
Blocks: 487757

Comment 3

8 years ago
Serge, want to submit a patch? I can review and land it.
(Assignee)

Comment 4

8 years ago
Created attachment 390685 [details] [diff] [review]
(Av1) 2 config.mk
[Checkin: Comment 5]

Fwiw, this was not (entirely) true (anymore) anyway, due to 'jpeg3250':
http://mxr.mozilla.org/mozilla-central/search?string=%5B%5E_S%5DVERSION_NUMBER&regexp=on&case=on
Assignee: general → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #390685 - Flags: review?(gal)

Updated

8 years ago
Attachment #390685 - Flags: review?(gal) → review+

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

8 years ago
Comment on attachment 390685 [details] [diff] [review]
(Av1) 2 config.mk
[Checkin: Comment 5]


http://hg.mozilla.org/mozilla-central/rev/7accd82ab321
Attachment #390685 - Attachment description: (Av1) 2 config.mk → (Av1) 2 config.mk [Checkin: Comment 5]
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

8 years ago
Peter, could you look into jsOS240.def? (which is the last occurrence)
Assignee: sgautherie.bz → general
Status: ASSIGNED → NEW
Flags: in-testsuite-

Comment 7

8 years ago
Serge, jsOS240.def is obsolete (and apparently has been for years, since when is there no jsOS240.dll any more?), it doesn't even list the symbols with the currently used calling convention. And I can very well compile js/src without it. Please just remove that file.
(Assignee)

Comment 8

8 years ago
Created attachment 390757 [details] [diff] [review]
(Bv1) Remove jsOS240.def
[Checkin: Comment 9]

Per comment 7.
Assignee: general → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #390757 - Flags: review?(mozilla)

Updated

8 years ago
Attachment #390757 - Flags: review?(mozilla) → review+
(Assignee)

Comment 9

8 years ago
Comment on attachment 390757 [details] [diff] [review]
(Bv1) Remove jsOS240.def
[Checkin: Comment 9]


http://hg.mozilla.org/mozilla-central/rev/1f8bcac8854b
Attachment #390757 - Attachment description: (Bv1) Remove jsOS240.def → (Bv1) Remove jsOS240.def [Checkin: Comment 9]
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.