Closed Bug 488840 Opened 12 years ago Closed 12 years ago

Don't display the line between folders in folder sidepane

Categories

(Thunderbird :: Folder and Message Lists, enhancement)

All
Windows Vista
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: andreasn, Assigned: philor)

References

Details

Attachments

(3 files, 2 obsolete files)

Currently there is a line between the folders in the folder pane, but neither Live Mail, (file) explorer or Firefox (in the bookmark library) does this.
I suggest we use the same behavior for Thunderbird.
This also affects the message thread pane (well, everywhere basically), but I think that is a good thing.
Blocks: 488060
Severity: normal → enhancement
Flags: blocking-thunderbird3+
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.0rc1
Attached patch patch to remove tree lines (obsolete) — Splinter Review
Ok, here's the patch to remove the tree lines from Windows builds
Assignee: nobody → clarkbw
Attachment #373309 - Attachment is obsolete: true
Attachment #377343 - Flags: review?(bienvenu)
Comment on attachment 377343 [details] [diff] [review]
patch to remove tree lines

when you're back on windows can you take a look at this patch?
Whiteboard: [waiting on review bienvenu]
people have gotten very unhappy in the past when we've removed the lines from the thread pane, since it makes it harder to figure out the reply hierarchy.

I think getting rid of the lines in the folder pane produces a much cleaner look, and wouldn't be an issue. Would it be weird to get rid of the folder pane lines but not the thread pane lines? It does seem odd that changing folderPane.css would change threadPane as well.
David: yeah, I think that makes sense. Will fix up a patch that only affects the folder pane, as this was my main target.
(In reply to comment #4)
> people have gotten very unhappy in the past when we've removed the lines from
> the thread pane, since it makes it harder to figure out the reply hierarchy.

Ok, though I think it's been gone from the Linux builds for a while now.

> I think getting rid of the lines in the folder pane produces a much cleaner
> look, and wouldn't be an issue. Would it be weird to get rid of the folder pane
> lines but not the thread pane lines? It does seem odd that changing
> folderPane.css would change threadPane as well.

The css hierarchy is a little messed up in that aspect.  I'm not sure how it was originally intended to work.
Attachment #377343 - Flags: review?(bienvenu) → review-
Comment on attachment 377343 [details] [diff] [review]
patch to remove tree lines

removing this until we get a new patch
Whiteboard: [waiting on review bienvenu] → [needs updated patch]
This patch only removes the tree lines from the folder pane but leaves them in the thread list
Attachment #377343 - Attachment is obsolete: true
Attachment #381104 - Flags: review?(philringnalda)
Whiteboard: [needs updated patch] → [waiting on review]
We don't actually want tree lines in the folder pane on any platform, in any theme, so let's just kill http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWidgets.xml#1777 (and back out the over-aggressive Gnomestripe CSS, too, so we get them back in the thread pane).
Let's just pretend I didn't copy the mailWidgets.xml link, where I was idly wondering wtf we wanted treelines for, instead of http://mxr.mozilla.org/comm-central/source/mail/base/content/messenger.xul#209, and let's further pretend that I didn't then try out a patch with what I pasted instead of what I wanted :)
But, once you actually remove the attribute from the right file, it works.

The downside is that it makes life difficult for a third-party theme that incomprehensibly wants to have treelines in the folder pane.

The upside is that it makes life difficult for a third-party theme that incomprehensibly wants to have treelines in the folder pane :)
Attachment #381232 - Flags: ui-review?(clarkbw)
Attachment #381232 - Flags: review?(mkmelin+mozilla)
Comment on attachment 381104 [details] [diff] [review]
remove tree lines from folderPane only

nothing to see here
Attachment #381104 - Flags: review?(philringnalda)
Comment on attachment 381232 [details] [diff] [review]
Cut them off at the roots

and the gnomestripe theme change ftw!
Attachment #381232 - Flags: ui-review?(clarkbw) → ui-review+
Attachment #381232 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 381232 [details] [diff] [review]
Cut them off at the roots

Looks good! r=mkmelin
Assignee: clarkbw → philringnalda
Whiteboard: [waiting on review]
http://build.mozillamessaging.com/mercurial/comm-central/rev/063d4c9ed5ea
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: Thunderbird 3.0rc1 → Thunderbird 3.0b3
(In reply to comment #11)
>Cut them off at the roots
> 
> But, once you actually remove the attribute from the right file, it works.
> 
> The downside is that it makes life difficult for a third-party theme that
> incomprehensibly wants to have treelines in the folder pane.

We could wait for the inevitable Bug that will come from the the guy who has set up a complex local folder hierarchy, or we could find a better way.

Personally, I don't mind the removal of treelines in the folderpane, but without the attribute, I don't think it's even possible to restore them using userChrome.

xref bug 430852
Well, it took me two minutes to successfully do it in userChrome, mostly because I forgot that it was chrome/userChrome.css, and then I had to answer the phone, so let's wait and see rather than prepanicking.
You need to log in before you can comment on or make changes to this bug.