48887 - OpenURL AppleEvent cuts off last character of URL

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Patrick C. Beard]

Consistently, using a build from 8/12/2000, sending a GetURL AppleEvent to the
browser cuts off the last character. Run this script:

tell application "NetscapeDebug"
	GetURL "http://www.mozilla.org"
end tell

And the browser will tell you it can't load "www.mozilla.or".

Comment 1

[Simon Fraser [no longer active]]

I have a fix

Comment 2

[marlon bishop]

changing severity to major

Comment 3

[marlon bishop]

*** Bug 51373 has been marked as a duplicate of this bug. ***

Comment 4

[Simon Fraser [no longer active]]

*** Bug 51805 has been marked as a duplicate of this bug. ***

Comment 5

[rubydoo123]

simon - go ahead and check this in

Comment 6

[Simon Fraser [no longer active]]

Fix checked in.

Comment 7

[Loco]

Updating QA Contact.

Comment 8

[Zach Lipton [:zach]]

verified 2000092711 OS9.

Comment 9

[Simon Fraser [no longer active]]

Reopening for OpenURL, which suffers the same problem. Dammit.

Comment 10

[Simon Fraser [no longer active]]

Patch:

Index: mozilla/xpfe/bootstrap/appleevents/nsAESpyglassSuiteHandler.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/bootstrap/appleevents/
nsAESpyglassSuiteHandler.cpp,v
retrieving revision 1.4
diff -u -2 -r1.4 nsAESpyglassSuiteHandler.cpp
--- nsAESpyglassSuiteHandler.cpp	2000/06/20 23:06:01	1.4
+++ nsAESpyglassSuiteHandler.cpp	2000/10/31 19:44:24
@@ -148,5 +148,5 @@
 	ThrowIfNil(urlString);
 	
-	directParameter.GetCString(urlString, dataSize);
+	directParameter.GetCString(urlString, dataSize + 1);
 	
 	nsMacCommandLine&  cmdLine = nsMacCommandLine::GetMacCommandLine();

This is exactly the same patch that was applied for the GetURL fix.

Comment 11

[Patrick C. Beard]

r=beard

Comment 12

[selmer (gone)]

Who is the super reviewer?  Please get the super review, do the proper testing
and move to [rtm+] state ASAP.

Comment 13

[Scott Collins]

extraction didn't count the terminator before.  standard fix.  sr=scc

Comment 14

[Simon Fraser [no longer active]]

have r= and sr=, so back to rtm+

Comment 15

[Phil Peterson]

PDT marking [rtm++]. Please check in to the branch ASAP.

Comment 16

[Simon Fraser [no longer active]]

Fix checked into the branch. Here's what was checked in:

Index: mozilla/xpfe/bootstrap/appleevents/nsAESpyglassSuiteHandler.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/bootstrap/appleevents/
nsAESpyglassSuiteHandler.cpp,v
retrieving revision 1.4
retrieving revision 1.4.16.1
diff -r1.4 -r1.4.16.1
150c150
< 	directParameter.GetCString(urlString, dataSize);
---
> 	directParameter.GetCString(urlString, dataSize + 1);


To verify this bug, open the Script Editor application, and make a new script 
with the contents:

tell application "Netscape 6"
	OpenURL "www.mozilla.org"
end tell

and run it. Before the fix, you'd see an error dialog that "www.mozilla.or" could 
not be found. After the fix, this should load http://www.mozilla.org/ in a new 
window.

Comment 17

[Simon Fraser [no longer active]]

Also checked the fix into the trunk.

Comment 18

[Loco]

VERIFIED on Mac OS 9.0.4 11-07-17 branch bits.  Regressed to 11-05-08 branch bits 
on Mac also.

Comment 19

[Hixie (not reading bugmail)]

Reassigning QA Contact for all open and unverified bugs previously under Lorca's
care to Gerardo as per phone conversation this morning.

Comment 20

[Madhur Bhatia]

QA contact updated

Comment 21

[luis rincon]

verified on build 2001-07-17-07-trunk