StretchDIBits takes too long - switch between optimizations at run time

RESOLVED FIXED

Status

()

Core
Widget: Win32
--
critical
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: blassey, Assigned: vlad)

Tracking

Trunk
All
Windows CE
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #484864 +++

We will have more than one code path for painting on windows, right now the code path is chosen at build time with preprocessor macros. It would be better to choose the path at run time based on prefs.
Created attachment 373749 [details] [diff] [review]
use pref to determine this at runtime

This depends on bug 488910

This patch adds a mozilla.widget.render-mode pref, that takes an int that corresponds to the new WinRenderMode enum.  It's only read in at start time, though we could add a pref observer to toggle it at runtime as well.

Most of this is just an indentation change, sadly; I can see if I can coax a diff -w patch out of hg if that would be easier to review.
Assignee: nobody → vladimir
Attachment #373749 - Flags: review?
Attachment #373749 - Flags: review? → review?(jmathies)

Comment 2

9 years ago
Hmm, can you post a updated patch? This didn't apply cleanly to m-c.
It won't, not without the patches in bug 488910.

Updated

9 years ago
Attachment #373749 - Flags: review?(jmathies) → review+

Comment 4

9 years ago
Comment on attachment 373749 [details] [diff] [review]
use pref to determine this at runtime

Alright, just eye balling it everything looked ok.
http://hg.mozilla.org/mozilla-central/rev/7fc81369ff6a
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.