488928 - statusText is set twice in Downloader::onStopRequest

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/src/nsUpdateService.js.in#2683

I suspect this might be causing bug 477597 as well

Comment 1

[Robert Strong (they/them - no direct email)]

btw: this makes test_0030_general.js pass with a XULRunner by itself

Comment 2

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/176afb7235f8

Comment 3

[Robert Strong (they/them - no direct email)]

This code path is in the test suite already so adding in‑testsuite even though this is just removing unnecessary code

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 373395 [details] [diff] [review]
patch rev1

Drivers, this patch removes code that sets a value that is immediately set ot a new value. With this code removed the xpcshell test test_0030_general.js passes on standalone XULRunner and likely will also pass for fennec (bug 477597)

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 373395 [details] [diff] [review]
patch rev1

a191=beltzner

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7b05bd6c2858