488954 - TM: Nonsensical AMO statistic graph in latest nightly

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: screenshot

I get some extra lines at the graph above and when I zoom out it looks like the mess in the attached screenshot.

I don't know if this is a problem with the nightly I'm on - Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre

Safari doesn't have this issue. Is this JS-related?

Comment 1

[Dave Garrett]

Latest Shiretoko nightly is affected too. I got problems right away from a new profile, without the need to zoom. Zooming just made it worse.

This is almost certainly due to one of the many TM fixes in the latest nightlies. For 3.5b4pre, the 17th's nightly is fine and the 18th has this bug.

Setting javascript.options.jit.content to false fixes this.

Comment 2

[Dave Garrett]

This seems to be fixed in latest Minefield nightly, so this is currently 1.9.1 only. Just needs whatever fixed it to get pushed over.

Comment 3

[Mike Shaver (:shaver emeritus)]

Can someone track down that change, maybe using the tracemonkey nightlies and hourlies?  Definitely want to make sure that it gets merged for b4.

Comment 4

[Dave Garrett]

The fix was first in the Minefield nightly for the 16th. Will see if I can narrow it down more.

Comment 5

[Dave Garrett]

Fix is in here somewhere:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=727474146624&tochange=9dc4b85b3470

Comment 6

[Dave Garrett]

Tracemonkey branch range for fix, from nightlies:
http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=49643dfd3008&tochange=78a21b8efe1b

I don't know where to find old enough Tracemonkey hourlies to check further.

Comment 7

[Dave Garrett]

Fix was in bug 488015, bug 487845, or one of the 2 tweaks to ComputeThis_tn() from Andreas Gal (no bug listed). They've all been pushed to 1.9.1 branch and this bug is no longer present in the latest nightly.

Comment 8

[Andreas Gal :gal]

I appologize for the scattered patches there. Thanks for sorting this out.

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on builds (using the URL listed in the bug): Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090428 Minefield/3.6a1pre ID:20090428031037

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090427 Shiretoko/3.5b5pre ID:20090427031112