Closed
Bug 489030
Opened 15 years ago
Closed 15 years ago
Rename mozStorageValueArray.* to mozStorageArgValueArray.*
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
Details
Attachments
(1 file)
|
13.99 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
It'll better reflect the only class that is (now) in the file. Also, let's update it to follow the style guidelines too!
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #373516 -
Flags: review?(bugmail)
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs review asuth]
|
||
Comment 2•15 years ago
|
||
Comment on attachment 373516 [details] [diff] [review] v1.0 NS_ENSURE_INDEX_VALUE sounds pretty generic/non-local for something local to a single file. Unless you're going to migrate it to a more generic header, perhaps lose the NS_? The elimination of temporaries makes things much cleaner!
Attachment #373516 -
Flags: review?(bugmail) → review+
|
|
||
Updated•15 years ago
|
Whiteboard: [needs review asuth] → [can land]
|
|
Assignee | |
Comment 3•15 years ago
|
||
With comments addressed - http://hg.mozilla.org/mozilla-central/rev/25386c8ca677
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•