489142 - JPEG decoder does not use fastpath when CMS mode is tagged-only

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Ilpo Ruotsalainen]

User-Agent:       Opera/9.63 (X11; Linux i686; U; en) Presto/2.1.1
Build Identifier: 

When CMS is enabled in tagged-only mode, the JPEG decoder does not use the direct YCC->ARGB path even for images where it could be used (ie. images without an ICC profile).

Reproducible: Always

Comment 1

[Ilpo Ruotsalainen]

Attachment: Fix for the issue

Average execution time for my JPEG loading benchmark case goes down from 414.67sec to 399.10sec on a 1GHz SnapDragon (ARMv7) with this patch.

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 373630 [details] [diff] [review]
Fix for the issue

Nice catch.

Do you need someone to check this in for you?

Comment 3

[Ilpo Ruotsalainen]

(In reply to comment #2)
> Do you need someone to check this in for you?

Yes please.

Comment 4

[Justin Lebar (not reading bugmail)]

Marking as checkin-needed.

Comment 5

[Justin Lebar (not reading bugmail)]

And removing checkin-needed; I'll just check this in myself when my commit access request goes through.

Do we need to get another review of this, since the r+ is a year old?  JOEDREW, what do you think?

Comment 6

[Joe Drew (not getting mail)]

If the patch still applies and/or only has some fuzz, check it in!

Comment 7

[Justin Lebar (not reading bugmail)]

http://hg.mozilla.org/mozilla-central/rev/3c5313a9c437