489196 - [10.6] Help menu does not include Apple search in non-English builds

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of Help menu using latest 1.9.1 nightly

Seen while running Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1b4pre) Gecko/20090420 Shiretoko/3.5b4pre

STR:
1. Open Help menu
2. Observe attached screenshot

The file menu shows normally using the latest trunk nightly, Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2a1pre) Gecko/20090420 Minefield/3.6a1pre.

Comment 1

[Marcia Knous [:marcia]]

This does not happen on my 10.5 machines running the same build. So far I have only see it using 10.6

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Josh: known issue with 10.6?

Comment 3

[Marcia Knous [:marcia]]

Oddly, using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1b4pre) Gecko/20090421 Shiretoko/3.5b4pre the menu has now returned to its normal state.

Comment 4

[Steven Michaud [:smichaud] (Retired)]

I can't reproduce this.  I tested with today's Minefield, Shiretoko and GranParadiso nightlies.

What you saw, Marcia, might have been a one-time quirk.

Did you see it more than once?

Comment 5

[Marcia Knous [:marcia]]

I have not seen it more than once. I think we can close this as WFM now, but I will be keeping an eagle eye out to see if it happens again.

Comment 6

[Josh Aas]

Whatever is going on here we don't need to block on it.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Please renominate for 3.6 if we can get it reproducible.

Comment 8

[Marcia Knous [:marcia]]

Reopening because this has resurfaced using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1b5pre) Gecko/20090430 Shiretoko/3.5b5pre.

Comment 9

[Marcia Knous [:marcia]]

Steven suggested I try this with a new profile, and I do not see the issue with a new profile.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

MArcia, can you run Shiretoko with this specific profile on your 10.5 machine? Would be interesting to know why that happens and if it is reproducible there too. Further narrowing it down what caused this in that profile would be helpful.

Comment 11

[Marcia Knous [:marcia]]

Will do as soon as I install the most updated seed. I am curious to see if the problem will still exist on that seed.

Comment 12

[Marcia Knous [:marcia]]

So I have now updated to a new seed and I have yet seen this specific issue. Would prefer to keep it open for a bit longer to see if it manifests itself again.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

See bug 504818 for a similar / the same issue with 3.5 on OS X 10.5.7. Not yet clear, if bug 504818 is a dupe.

Comment 15

[Kohei Yoshino [:kohei]]

This has been on my mind lately. Isn't it a problem of localized builds? Still reproducible with the latest trunk.

Search bar is available:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20091223 Minefield/3.7a1pre

Search bar is not available:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; fr; rv:1.9.3a1pre) Gecko/20091223 Minefield/3.7a1pre
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; ja-JP-mac; rv:1.9.3a1pre) Gecko/20091223 Minefield/3.7a1pre

Thunderbird has the same problem.

Search bar is available:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20091223 Shredder/3.1a1pre

Search bar is not available:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; fr; rv:1.9.3a1pre) Gecko/20091221 Shredder/3.1a1pre
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; ja-JP-mac; rv:1.9.3a1pre) Gecko/20091221 Shredder/3.1a1pre

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

See comment 0 where it happened with an en-US build.

Comment 17

[Steven Michaud [:smichaud] (Retired)]

(In reply to comment #15)

I can reproduce what you report -- not only on the trunk, but in both
FF 3.5.6 and 3.0.16!

Since Marcia's original report isn't reproducible, I'm going to
repurpose this bug.

I did my tests with the OS language set to English.  But I also tried
one test with it set to French, and this made no difference.

I haven't (yet) tested with more than the fr and ja-JP-mac builds.
It's possible some non-English builds don't have this problem.

I have a hunch [NSApplication setHelpMenu:] (new with 10.6) will be
the solution.

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #17)
> I haven't (yet) tested with more than the fr and ja-JP-mac builds.
> It's possible some non-English builds don't have this problem.

It should affect all non-English languages that have localized the name of the Help menu.

> I have a hunch [NSApplication setHelpMenu:] (new with 10.6) will be
> the solution.

Yes, that's what other applications use to fix this problem on 10.6. 

(Also note that prior to 10.6, the search field wouldn't show up if the OS did not have language resources for the language of your bundle, e.g. Slovenian; that's an entirely separate bug from this 10.6 issue.)

Comment 19

[Steven Michaud [:smichaud] (Retired)]

Attachment: Fix

Here's a patch for this bug.

The tryservers won't do localized builds.  But here's a French (fr)
localized build that I made myself (with my patch):
http://people.mozilla.com/~stmichaud/bmo/firefox-3.7a1pre.fr.mac.bugzilla489196-smichaud.dmg

Comment 20

[Josh Aas]

Comment on attachment 420177 [details] [diff] [review]
Fix

+// Present (and documented) on OS X 10.6 and above.
+- (void)setHelpMenu:(NSMenu *)helpMenu;

Might want to improve this comment to make it clear that this call does not exist on 10.5 and we're only declaring it here to avoid compiler warnings on SDKs prior to 10.6.

Comment 21

[Steven Michaud [:smichaud] (Retired)]

Landed on trunk, with the change Josh asked for:
http://hg.mozilla.org/mozilla-central/rev/a970bbfb56f7

Just to be sure, I also compiled the patch on 10.6 (32-bit and
64-bit), just to make sure my declaration of [NSApplication
setHelpMenu:] didn't cause trouble there (it didn't).

Comment 22

[Nomis101]

Oh nice, this patch has also fixed the same issue for Thunderbird trunk builds on 10.6. Since 10.6 I've missed the Apple search in the help menu in Thunderbird, since this checkin its back. :-)
(Only tested with my own german TB 3.2a1pre build)

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #22)
> Oh nice, this patch has also fixed the same issue for Thunderbird trunk builds
> on 10.6. Since 10.6 I've missed the Apple search in the help menu in
> Thunderbird, since this checkin its back. :-)
> (Only tested with my own german TB 3.2a1pre build)

CC'ing Mark from the Thunderbird team, so they are aware of it.

Comment 24

[Nomis101]

Is it planed to fix this (including Bug 539317) also in 1.9.2? I see this Bug in Lanikai 3.1 Alpha 1 and it would be nice to have a (fully) 10.6-compatible TB 3.1.

Comment 25

[Steven Michaud [:smichaud] (Retired)]

I've asked for 1.9.2-branch approval for my patch for bug 539317 -- which is a better version of this bug's patch.

Comment 26

[Kohei Yoshino [:kohei]]

Attachment: Firefox 3.6.9 ja-JP-mac

Looks good!