JS Component does not have a method named "onError"' when calling method: [nsIWifiListener::onError]

VERIFIED FIXED

Status

()

defect
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: marcia, Assigned: dougt)

Tracking

({verified1.9.1})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Seen while running Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2a1pre) Gecko/20090420 Minefield/3.6a1pre on a wired connection.

STR:
1. Visit http://people.mozilla.org/~dougt/geo.html
2. Select "Tell Them"
3. View this error in console:

Error in Console: Error: [Exception... "'JavaScript component does not have a method named: "onError"' when calling method: [nsIWifiListener::onError]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "<unknown>"  data: no]
Flags: blocking1.9.1?
Occurs on Win Vista as well using a wired connection.
OS: Mac OS X → All
Hardware: x86 → All
Status: NEW → ASSIGNED
when wifi fails to find any access points, it waits a bit, sends an error to listeners, then shutdowns.  not having a function called onError in the location provider code (the sole listener of the wifi stuff) generates this error.  It isn't critical that we implement onError, but without it we get errors in the jsconsole for non-wifi users.

this patch just adds the right function which is essentially a noop.
Assignee: nobody → doug.turner
Attachment #373760 - Flags: superreview?(jst)
Attachment #373760 - Flags: review?(jst)
Comment on attachment 373760 [details] [diff] [review]
adds a stub onError()

verbal.  really.
Attachment #373760 - Flags: superreview?(jst)
Attachment #373760 - Flags: superreview+
Attachment #373760 - Flags: review?(jst)
Attachment #373760 - Flags: review+
Attachment #373760 - Flags: approval1.9.1?
http://hg.mozilla.org/mozilla-central/rev/6f8a29abe2bf
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
marcia, can you try tomorrow trunk build.
Attachment #373760 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 373760 [details] [diff] [review]
adds a stub onError()

a191=beltzner
Verified fixed on the trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090421 Minefield/3.6a1pre and  Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090421 Minefield/3.6a1pre. No error on console when connecting from a wired machine.
Status: RESOLVED → VERIFIED
Flags: blocking1.9.1?
Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre.
You need to log in before you can comment on or make changes to this bug.