Closed Bug 489280 Opened 14 years ago Closed 14 years ago

port networking to x86-64 Mac OS X

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file)

fix v1.0
3.06 KB, patch
smichaud
: review+
roc
: superreview+
Details | Diff | Splinter Review 
Need to port our networking module (NetLib) to x64-64 Mac OS X.
Attached patch fix v1.0 — — Splinter Review 
Aside from some little compiler stuff and picking a UA string, the big thing this patch does is disable the Apple file decoder under 64-bit. That will be a major pain to port and if we need to we can port it later. We should disable it now and file a bug on porting it, no need to hold up the 64-bit port for that.

Apple, at this time, uses just "Intel" for their UA string arch for 32-bit and 64-bit.
Attachment #373790 - Flags: review?(smichaud)
Comment on attachment 373790 [details] [diff] [review]
fix v1.0

Looks fine to me.
Attachment #373790 - Flags: review?(smichaud) → review+
Attachment #373790 - Flags: superreview?(roc)
Attachment #373790 - Flags: superreview?(roc) → superreview+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/221b58f349cc
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
(In reply to comment #1)
> Apple, at this time, uses just "Intel" for their UA string arch for 32-bit and
> 64-bit.

That seems like it's probably not the best idea; we might want to have a bug on file on fixing it.
I filed bug 489586 on the UA string issue.
Blocks: 519021
You need to log in before you can comment on or make changes to this bug.