Closed
Bug 489299
Opened 15 years ago
Closed 15 years ago
TestSynchronization.cpp failed to compile with Sun Studio
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
Attachments
(1 file, 1 obsolete file)
|
4.07 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
Sun Studio C++ doesn't have __FUNCTION__ but __func__ Also it requires to add -features=extensions in command line.
|
||
Updated•15 years ago
|
Attachment #373801 -
Flags: review?(benjamin) → review+
More changes are required for debug builds now. lock_t conflicts with a system header on Solaris.
Attachment #373801 -
Attachment is obsolete: true
Attachment #377110 -
Flags: review?(benjamin)
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 377110 [details] [diff] [review] patch v2 Delegating review to cjones. I'm ok with this, but it might be simpler to put TestDeadlockDetector.cpp in an anonymous namespace.
Attachment #377110 -
Flags: review?(benjamin) → review?(jones.chris.g)
Comment on attachment 377110 [details] [diff] [review] patch v2 OK by me.
Attachment #377110 -
Flags: review?(jones.chris.g) → review+
http://hg.mozilla.org/mozilla-central/rev/660b51f96638
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•