489339 - Tab still doesn't detach if dragged to the desktop

Status: VERIFIED DUPLICATE of bug 487263

(Firefox :: Tabbed Browser, defect)

Description

[Luke Iliffe (Harlequin99)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090421 Shiretoko/3.5b4pre Firefox/3.0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090421 Minefield/3.6a1pre

Since bug 475066 tried to fix the dragging of a tab to the desktop to detach a tab I have never been getting it to work completely. Even after today's bug 488984 fixed the dragging into content area to detach I still can't detach a tab if I drag a tab right over the tabbar to the desktop, or up over the menu bar and onto the desktop. In all these situations nothing happens.

Reproducible: Always

Steps to Reproduce:
1. open minefield with a new profile, open a second tab
2. drag a tab either left over the tabbar onto the desktop, or up over the top of the window onto the desktop.
3.
Actual Results:  
nothing happens

Expected Results:  
detach the tab into a new window

Comment 1

[Alice0775 White]

I think this behavior is intentionally by https://bugzilla.mozilla.org/show_bug.cgi?id=475066#c56.
However, it cannot agree with this behavior. 

The followinf patch can fix the bug.
Detach tab by drop tab onto the desktop whole region of the outside of a browser.

tabbrowser.xml
-            // Deatch happens only if the tab was dropped below the tabbar.
-            // That is applied even if it was dropped outside the browser
-            // window.
+            // Deatch happens only if the tab was dropped below the tabbar
+            // and the desktop whole region of the outside of a browser window.
            var bo = this.mTabContainer.mTabstrip.boxObject;
            var tabbarEndScreenY = bo.screenY + bo.height;
-            if (aEvent.screenY > tabbarEndScreenY) {
+            if (aEvent.screenY > tabbarEndScreenY ||
+               aEvent.screenY < window.screenY ||
+               aEvent.screenX < window.screenX  ||
+               window.screenX + window.outerWidth < aEvent.screenX) {
              var draggedTab = dt.mozGetDataAt(TAB_DROP_TYPE, 0);
              this.replaceTabWithWindow(draggedTab);
            }
            aEvent.stopPropagation();

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

Bug 487263 described the exact problem, dragging a tab along the tab-bar and out the right side of the browser to the desktop does not detach the tab, in fact nothing happens.  The bug was marked as dupe, and the dupe states its FIXED, however the issue remains with the STR in 487263, so either its not a dupe, or 475066 is still not totally correct in fixing the problem. 

Tested using today's build/trunk: 
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090421 Minefield/3.6a1pre Firefox/3.0.7 ID:20090421041537