489433 - larry UI in portrait mode is cut off

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

In portrait mode on wince builds, I load up any website (mozilla.org), and click on the larry button (to the left of the url/title) and I see the larry UI pop up.

In landscape mode, I can view the whole UI, but in portrait mode I lose some of it.  Attempting to pan does not help my situation as only the web page pans.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

this patch has everything but updated images for larry (48px and transparent background) and the lock/unlock images (24px and transparent).

Text has been updated and re-arranged based on Madhava's mockups:
http://www.grabup.com/uploads/f93b892110889832bf9901e8f892324e.png
http://www.grabup.com/uploads/e8d7be9ede80ccb0240870daf1fcdf3c.png

Screenshots:
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-larry-unknown.png
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-larry-verified.png

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 378782 [details] [diff] [review]
patch

I was waiting for new larry and lock/unlock images before requesting review. Those images are now part fo bug 494551, so I'm going to ask for review now, then update then images in bug 494551.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2 (no bitrot and using new theme images)

This patch merges to trunk and uses the new theme where appropriate (images and 'mm' padding)

It also reverts all but one ID to "identity-popup-*" (it actually hurt, but I did it)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 381203 [details] [diff] [review]
patch 2 (no bitrot and using new theme images)

>diff --git a/chrome/content/browser.js b/chrome/content/browser.js

>   setMode: function(newMode) {

>     // Update the popup too, if it's open
>-    if (this._identityPopup.state == "open")
>+    if (this._identityPopup.hidden == false)

!hidden rather than hidden == false?

>   handleIdentityButtonEvent: function(event) {

>+    if (this._identityPopup.hidden == true)

ditch the "== true"?

>+  handleEvent: function(event) {
>+    this.hide();

Add a comment saying this only handles blurs?

>diff --git a/themes/hildon/browser.css b/themes/hildon/browser.css

>-#identity-popup-content-box > description {

>-  white-space: pre-wrap;

>-#identity-popup-content-box > label {

>-  white-space: pre-wrap;

Looks like you forgot to move this to the common label/description rule? You did keep it in the wince version.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with those changes:
http://hg.mozilla.org/mobile-browser/rev/21896505976e