Update videocontrols -moz-border-radius to match trunk

VERIFIED FIXED in mozilla1.9.1b4

Status

()

Toolkit
Video/Audio Controls
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Dolske, Assigned: Dolske)

Tracking

({verified1.9.1})

unspecified
mozilla1.9.1b4
verified1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

9 years ago
Created attachment 373925 [details] [diff] [review]
Patch v.1

Due to the behavior noted in bug 474521, the -moz-border-radius used in the video control's CSS was 3px, instead of the 4px used on trunk. At the time this was needed to make 191 and trunk appear the same visually.

Whatever was causing the different rendering on 191 seems to have been fixed, and thus the relevant curved bits on 191 don't look correct anymore. This patch updates the CSS to patch the 4px value already used on trunk.
(Assignee)

Comment 1

9 years ago
Created attachment 373928 [details]
Screenshot / comparison

trunk on top, 1.9.1 (with this patch) on bottom. I also cut'n'pasted a bit of 191 over trunk, so that the changed areas are more readily comparable by just zooming in. As you can see, they're identical.
Attachment #373928 - Flags: ui-review?(jboriss)
Attachment #373928 - Flags: ui-review?(jboriss) → ui-review+
Comment on attachment 373928 [details]
Screenshot / comparison

+ing
(Assignee)

Updated

9 years ago
Attachment #373925 - Flags: approval1.9.1?
Comment on attachment 373925 [details] [diff] [review]
Patch v.1

a191=beltzner
Attachment #373925 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Comment 4

9 years ago
Pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ea774a371442
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b4

Comment 5

9 years ago
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
rv:1.9.2a1pre) Gecko/20090507 Minefield/3.6a1pre 
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre)
Gecko/20090507 Shiretoko/3.5b5pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
(Assignee)

Updated

8 years ago
Component: Video/Audio → Video/Audio Controls
Product: Core → Toolkit
QA Contact: video.audio → video.audio
Target Milestone: mozilla1.9.1b4 → mozilla1.9.2a1
Version: 1.9.1 Branch → unspecified
(Assignee)

Updated

8 years ago
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b4
You need to log in before you can comment on or make changes to this bug.