Closed Bug 489485 Opened 11 years ago Closed 10 years ago

Making nsRect::ToNearest/Inner/OuterPixels member functions, not static

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: roc, Assigned: ryoqun)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

See bug 448830 comment 46. Making them static was a design error and should be fixed.

We should fix nsIntRect::ToAppUnits too.
Whiteboard: [good first bug]
I take this bug.
Attached patch patch v1Splinter Review
I made a patch for this. This was quite easy. I checked running the whole reftests. The result seems to be OK. :)
Attachment #376199 - Flags: review?(roc)
Attachment #376199 - Flags: superreview+
Attachment #376199 - Flags: review?(roc)
Attachment #376199 - Flags: review+
Keywords: checkin-needed
Whiteboard: [good first bug] → [needs landing][good first bug]
http://hg.mozilla.org/mozilla-central/rev/665b73eb15c8
Thanks!
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing][good first bug] → [good first bug]
Assignee: nobody → ryoqun
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.