Closed
Bug 489506
Opened 16 years ago
Closed 16 years ago
test_largemenu.xul fails when the screen size is an odd number
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
Details
Attachments
(1 file)
|
1.74 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
Hopefully the attached patch will make the problem clear.
I'm not 100% sure this is the right fix though, so requesting review. The test does pass with the patch on an odd-height screen.
Attachment #373992 -
Flags: review?(enndeakin)
|
||
Updated•16 years ago
|
Attachment #373992 -
Flags: review?(enndeakin) → review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 373992 [details] [diff] [review]
fix
Seems ok. The problem is caused because in the call to openPopupAtScreen, y may be a non-integer. Add a comment to that effect.
|
Assignee | |
Comment 2•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•