Closed Bug 489520 Opened 11 years ago Closed 11 years ago

browser.xml's feeds property can entrain documents inside the browser

Categories

(Toolkit :: XUL Widgets, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.1b4

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: fixed1.9.1, memory-leak)

Attachments

(1 file)

We have a known issue that with tabbrowsers, when a tab is closed, we have a number of things that entrain the <browser> element for that closed tab and prevent it from being garbage collected.  (We should probably try to address those, though.)

When this happens, the feeds property on the browser element (I'm not sure who sets it, but there's existing code to clear it on page transitions) can entrain the document and global object inside the browser (via link elements in that document) until the window containing the tabbrowser is closed.

Steps to reproduce (note that these may leak even with the patch without some other patches in my tree):
 * install leak-monitor; see http://dbaron.org/mozilla/leak-monitor/
 * start Firefox and load http://openfontlibrary.fontly.org/files
 * click on the "Name" (next to "Sort By")
 * press Ctrl-T to open a new tab
 * click on the [X] to close the old tab
 * wait a few seconds for garbage collection to happen

Actual results (without patch):  Two leak monitor alerts

Expected results (with patch): No leak monitor alerts
Flags: blocking1.9.1?
Attachment #374024 - Flags: review?(gavin.sharp)
Attachment #374024 - Flags: review?(gavin.sharp) → review+
Firefox browser.js code sets it. browser.xml having to know about a JS property set on it by Firefox-specific code isn't ideal, but this fix doesn't make things any worse, as you point out. We can fix that separately in another bug (I think there might already be one on file).
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
http://hg.mozilla.org/mozilla-central/rev/6049dbd9973c

Filed bug 489622 as followup on this part of comment 0:
> We have a known issue that with tabbrowsers, when a tab is closed, we have a
> number of things that entrain the <browser> element for that closed tab and
> prevent it from being garbage collected.  (We should probably try to address
> those, though.)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/472798140963
Keywords: fixed1.9.1
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b4
You need to log in before you can comment on or make changes to this bug.