Switch to using the toolkit support for toolbar customization sheets

RESOLVED FIXED in Firefox 3.6a1

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Steffen Wilberg, Assigned: philor)

Tracking

Trunk
Firefox 3.6a1
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Same as bug 489047, but for Firefox.
I don't have a Mac, so I'm not the best person to do this...
(Assignee)

Comment 1

9 years ago
Created attachment 374985 [details] [diff] [review]
Fix

I wish people would stop saying "I'd do it, but I don't have a Mac" since one of my arguments for taking the (pref-triggered part of) the patch is that it lets people without a Mac see what they are doing to the sheet-panel.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #374985 - Flags: review?(mano)
(Reporter)

Comment 2

9 years ago
Sure, but you originally wrote the pref-triggered part of this in bug 490282, which you filed a couple of days after I filed this bug...

Comment 3

9 years ago
> Sure, but you originally wrote the pref-triggered part of this in bug 490282,
> which you filed a couple of days after I filed this bug...

That's not an excuse since all that Phil did was to port my changes in Bug 406780 to Thunderbird (and the reason I went with the dynamic pref control was that I didn't have a Mac) and you could just have done the same.
(Reporter)

Comment 4

9 years ago
I haven't seen that bug either. And sorry for attributing your idea as Phil's.

Next time I file a Mac bug, I'll ask for hints on how to do this without a Mac instead...
(Assignee)

Comment 5

9 years ago
Nah, the secret is to put them on the defensive instead. "The Steve Jobs fanboys need to stop cluttering up browser/ code with their 'oh, my customize dialog must look just like Steve's precious ones' defines and use the copy in toolkit instead. I'd do it, but I can't stand to touch their 'oh, we're so much prettier than you' code." ;)

Comment 6

9 years ago
is it foreseen that this patch makes it into Fx 3.5?  it makes a big difference to my extension, totaltoolbar, in upgrading to 3.5 compatibility.
Beta 4 was the last beta, and you should be able to use that when updating your extension. Basically, if this patch breaks compatibility, then it's not a candidate for 3.5. Besides, it's probably not useful to take this for 3.5 anyway, since it's more of a maintenance thing rather than fixing something that's broken.
(Assignee)

Comment 9

9 years ago
http://hg.mozilla.org/mozilla-central/rev/2103cf22598c
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
You need to log in before you can comment on or make changes to this bug.