Closed
Bug 489583
Opened 15 years ago
Closed 15 years ago
TraceMonkey: ARM's ::asm_branch could do with being tidied up.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jbramley, Assigned: jbramley)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
7.62 KB,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
This came out of the work I've done for bug 488826. The patch is simple but makes the ::asm_branch method much tidier and easier to maintain. In addition, it corrects an error in the condition flags that are used for floating-point conditions: VFP "<" and "<=" conditions are fairly unintuitive and actually use the unsigned condition flags; the previous code used signed condition flags. Note that this patch was previously attached to bug 488826.
Assignee | ||
Updated•15 years ago
|
Attachment #374072 -
Flags: review?(vladimir)
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #374072 -
Attachment is obsolete: true
Attachment #384394 -
Flags: review?(vladimir)
Attachment #374072 -
Flags: review?(vladimir)
Attachment #384394 -
Flags: review?(vladimir) → review+
Assignee | ||
Updated•15 years ago
|
Whiteboard: fixed-in-tracemonkey
Comment 2•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/932295825469
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•