Closed Bug 489587 Opened 12 years ago Closed 12 years ago

Tidy up the status bar code in mailWindow.js

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
The current status bar code is a bit of a mess with strange bracket alignments, unnecessary things etc.

Here's a patch to tidy it up. The only functional change I've done is to drop the ensureStatusFields function - we now initialise the document element members in the constructor of nsMsgStatusFeedback, this saves calling ensureStatusFields every time we do something on the status bar.

This is the patch before the one that will start hooking up activity manager to the status bar - which I'd like to get in today if possible (for the test day).
Attachment #374075 - Flags: review?(bienvenu)
Blocks: 489588
Comment on attachment 374075 [details] [diff] [review]
The fix

this can be reduced to one if:

+    if (this._pendingStartRequests == 0 && !this._stopTimeoutID) {
+      if (this._meteorsSpinning && window.MsgStatusFeedback)
+        this._stopTimeoutID =
+          setTimeout('window.MsgStatusFeedback._stopMeteors();', 500);
+    }
Attachment #374075 - Flags: review?(bienvenu) → review+
Checked in with comment addressed, also fixed a couple of variable renames that I realised were wrong.

http://hg.mozilla.org/comm-central/rev/ea0ce6d551f5
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: Tidy up the status bar js code → Tidy up the status bar code in mailWindow.js
You need to log in before you can comment on or make changes to this bug.