489612 - Update mozStoragePrivateHelpers.* to follow style guidelines

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 374094 [details] [diff] [review]
v1.0

>diff --git a/storage/src/mozStorageAsyncStatementExecution.cpp b/storage/src/mozStorageAsyncStatementExecution.cpp
>--- a/storage/src/mozStorageAsyncStatementExecution.cpp
>+++ b/storage/src/mozStorageAsyncStatementExecution.cpp
>@@ -443,7 +443,7 @@ Connection::databaseElementExists(enum D
>   sqlite3_stmt *stmt;
>   int srv = ::sqlite3_prepare_v2(mDBConn, query.get(), -1, &stmt, NULL);
>   if (srv != SQLITE_OK)
>-      return ConvertResultCode(srv);
>+      return convertResultCode(srv);

4-space should be 2-space

>diff --git a/storage/src/mozStoragePrivateHelpers.h b/storage/src/mozStoragePrivateHelpers.h
>--- a/storage/src/mozStoragePrivateHelpers.h
>+++ b/storage/src/mozStoragePrivateHelpers.h
>@@ -65,7 +68,9 @@ nsresult ConvertResultCode(int aSQLiteRe
...
>+#endif // _mozStoragePrivateHelpters_h_
                                  ^
no t in helper

Comment 2

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

addresses review comments

Comment 3

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/4d9fc3354fbc