Update mozStoragePrivateHelpers.* to follow style guidelines

RESOLVED FIXED in mozilla1.9.2a1

Status

()

defect
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Tracking

Trunk
mozilla1.9.2a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Posted patch v1.0Splinter Review
No description provided.
Attachment #374094 - Flags: review?(bugmail)
Whiteboard: [needs review asuth]
Comment on attachment 374094 [details] [diff] [review]
v1.0

>diff --git a/storage/src/mozStorageAsyncStatementExecution.cpp b/storage/src/mozStorageAsyncStatementExecution.cpp
>--- a/storage/src/mozStorageAsyncStatementExecution.cpp
>+++ b/storage/src/mozStorageAsyncStatementExecution.cpp
>@@ -443,7 +443,7 @@ Connection::databaseElementExists(enum D
>   sqlite3_stmt *stmt;
>   int srv = ::sqlite3_prepare_v2(mDBConn, query.get(), -1, &stmt, NULL);
>   if (srv != SQLITE_OK)
>-      return ConvertResultCode(srv);
>+      return convertResultCode(srv);

4-space should be 2-space

>diff --git a/storage/src/mozStoragePrivateHelpers.h b/storage/src/mozStoragePrivateHelpers.h
>--- a/storage/src/mozStoragePrivateHelpers.h
>+++ b/storage/src/mozStoragePrivateHelpers.h
>@@ -65,7 +68,9 @@ nsresult ConvertResultCode(int aSQLiteRe
...
>+#endif // _mozStoragePrivateHelpters_h_
                                  ^
no t in helper
Attachment #374094 - Flags: review?(bugmail) → review+
Whiteboard: [needs review asuth] → [needs new patch]
Posted patch v1.1Splinter Review
addresses review comments
Whiteboard: [needs new patch] → [can land]
http://hg.mozilla.org/mozilla-central/rev/4d9fc3354fbc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.