489628 - avoid closure for attrChanged in tabbrowser.addTab

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

spin-off from bug 489622:

>  * the tab elements are leaked for multiple reasons:
> 
>    + one is that they're sometimes entrained by the closure attrChanged in the
> tabbrowser binding's addTab method.

Comment 1

[Dão Gottwald [:dao]]

Attachment: wip patch

I think this should fix it, but I haven't tested it yet..

Comment 2

[:Gavin Sharp [email: [e-mail]]]

That patch would likely also fix bug 358362.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch [Checked in: Comment 4]

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/d092e63f5f84

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch for 1.9.1 branch [Checked in: Comment 7]

same as for trunk, except for not removing the resetOwner method

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 374438 [details] [diff] [review]
patch for 1.9.1 branch
[Checked in: Comment 7]

a191=beltzner

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c17c67a0542c

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

This checkin was in a range identified with a Ts Shutdown regression on Windows:

Regression: Ts Shutdown increase 27.64% on WINNT 5.1 Firefox3.5
   Previous results:
       357.263 from build 20090506145316 of revision 486b76052a94 at 2009-05-06 14:53:00
   New results:
       456.0 from build 20090506155401 of revision 7aa4483585bd at 2009-05-06 15:54:00
http://graphs-new.mozilla.org/graph.html#tests=[{"machine":32,"test":36,"branch":3},{"machine":33,"test":36,"branch":3},{"machine":34,"test":36,"branch":3},{"machine":35,"test":36,"branch":3},{"machine":48,"test":36,"branch":3}]&sel=1241564040,1241736840

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No test failures since the checkin on 1.9.2 and 1.9.1. Looks like that another caused the Ts Shutdown regression given by comment 8. Marking as verified fixed.