Closed
Bug 489643
Opened 15 years ago
Closed 15 years ago
set sane default options in UNPACK_TAR
Categories
(Toolkit Graveyard :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mpk, Assigned: mpk)
Details
(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b99])
Attachments
(1 file)
|
846 bytes,
patch
|
benjamin
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Since April 8 "make package" for Fennec on FreeBSD is broken (see http://hg.mozilla.org/mobile-browser/pushloghtml?changeset=323cf18c81ad). The reason for this is that $(UNPACK_TAR) is now directly called in the installer makefile. UNPACK_TAR is set to "tar -x" which assumes that the default value for the -f parameter is - (stdin). But on some unices (one of them being FreeBSD) it is set to the first tape drive (e.g. /dev/sa0). Setting UNPACK_TAR to "tar -xf-" should cause no harm and avoid breaking the builds on platforms where some default settings from the days of yore still prevail.
Attachment #374116 -
Flags: review?(benjamin)
|
||
Updated•15 years ago
|
Attachment #374116 -
Flags: review?(benjamin) → review+
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
||
Comment 1•15 years ago
|
||
Comment on attachment 374116 [details] [diff] [review] change UNPACK_TAR from "tar -x" to "tar -xf-" [Checkin: Comment 1 & 3] http://hg.mozilla.org/mozilla-central/rev/26b0d1671937
Attachment #374116 -
Attachment description: change UNPACK_TAR from "tar -x" to "tar -xf-" → change UNPACK_TAR from "tar -x" to "tar -xf-"
[Checkin: Comment 1]
|
|
||
Updated•15 years ago
|
Attachment #374116 -
Flags: approval1.9.1?
|
|
||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs 1.9.1 landing: needs approval]
Target Milestone: --- → mozilla1.9.2a1
|
||
Comment 2•15 years ago
|
||
Comment on attachment 374116 [details] [diff] [review] change UNPACK_TAR from "tar -x" to "tar -xf-" [Checkin: Comment 1 & 3] a191=beltzner
Attachment #374116 -
Flags: approval1.9.1? → approval1.9.1+
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 374116 [details] [diff] [review] change UNPACK_TAR from "tar -x" to "tar -xf-" [Checkin: Comment 1 & 3] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/cfbfff2cff18
Attachment #374116 -
Attachment description: change UNPACK_TAR from "tar -x" to "tar -xf-"
[Checkin: Comment 1] → change UNPACK_TAR from "tar -x" to "tar -xf-"
[Checkin: Comment 1 & 3]
|
|
||
Updated•15 years ago
|
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1 landing: needs approval] → [fixed1.9.1b5]
|
|
||
Updated•15 years ago
|
Whiteboard: [fixed1.9.1b5] → [fixed1.9.1b99]
|
||
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•