Update mozStorageStatementWrapper.* to follow style guidelines

RESOLVED FIXED in mozilla1.9.2a1

Status

()

defect
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Tracking

Trunk
mozilla1.9.2a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch v1.0 (obsolete) — Splinter Review
There are some things that this file does inefficiently, but I'm not going to fix because I don't care, and people should not be using this interface anymore.
Attachment #374139 - Flags: review?(bugmail)
Whiteboard: [needs review asuth]
Comment on attachment 374139 [details] [diff] [review]
v1.0

>diff --git a/storage/src/mozStorageStatementWrapper.cpp b/storage/src/mozStorageStatementWrapper.cpp
>--- a/storage/src/mozStorageStatementWrapper.cpp
>+++ b/storage/src/mozStorageStatementWrapper.cpp
>+StatementWrapper::Step(PRBool *_hasMoreResults)
> {
>-    if (!mStatement)
>-        return NS_ERROR_FAILURE;
>+  if (!mStatement)
>+      return NS_ERROR_FAILURE;

4 => 2
Attachment #374139 - Flags: review?(bugmail) → review+
Whiteboard: [needs review asuth] → [needs new patch]
Posted patch v1.1Splinter Review
addresses review comments
Attachment #374139 - Attachment is obsolete: true
Whiteboard: [needs new patch] → [can land]
http://hg.mozilla.org/mozilla-central/rev/1d27d30234e2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.