Closed Bug 489679 Opened 11 years ago Closed 11 years ago

eliminate init method in video controls XBL binding

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: Dolske, Assigned: Dolske)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Attached patch Patch v.1Splinter Review
Neil's remark in bug 487719 comment 4 made me realize that having an init() method in the XBL binding is kind of silly. It's only ever called by the constructor, and everything it does it with this.Utils.

It cleans things up a bit to just move this code into Utils.init(). This patch just does 3 things:
  * whitespace indent changes
  * s/this.Utils/this/
  * s/this/binding/
Attachment #374165 - Flags: review?(enndeakin)
Attachment #374165 - Flags: review?(enndeakin) → review+
Pushed http://hg.mozilla.org/mozilla-central/rev/3f854d74c2f4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Version: 1.9.1 Branch → unspecified
Attachment #374165 - Flags: approval1.9.1?
Comment on attachment 374165 [details] [diff] [review]
Patch v.1

a191=beltzner
Attachment #374165 - Flags: approval1.9.1? → approval1.9.1+
Assignee: nobody → dolske
Component: Video/Audio → Video/Audio Controls
Product: Core → Toolkit
QA Contact: video.audio → video.audio
You need to log in before you can comment on or make changes to this bug.