489696 - Set up redirects for existing URLs to work with new Fx Uninstall Survey

Status: RESOLVED FIXED

(Webtools Graveyard :: Uninstall Survey, defect)

Description

[ken kovash]

We'll need our new Fx uninstall survey to work with existing URLs.  The existing URL structure looks like this:
https://survey.mozilla.com/results/add/?application=firefox&ua=3.0.8

The new survey will include embedding (via iframe or js solution) a surveygizmo survey within a mozilla.com page (e.g., www.mozilla.com/uninstall).  There will be a separate bug for the specific iframe/js implementation.

Comment 1

[Fred Wenzel [:wenzel]]

This needs to be tied into the "passing GET variables" stuff from bug 489698 comment 3.

Comment 2

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Wil: These htaccess changes to survey.mozilla.com forward people to the new uninstall page. To see how the new page looks/works, please refer to bug 489698.

Ken: I noticed that besides ua and application, there are two more, relevant GET variables (version and lang), which I also added to the ones being forwarded to surveymonkey. If that's not what we want, please speak up. (At any rate, they won't do any harm).

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 379677 [details] [diff] [review]
Patch, rev. 1

If that does what you want it works for me, although the URL is firefox-specific now.  Also, isn't this conflicting with bug 485950?

Comment 4

[Fred Wenzel [:wenzel]]

Ken: Did I misunderstand you, do I need to set up these redirects so that they only work when the client is Firefox? If survey.mozilla.org and your new survey are supposed to happily coexist, I need to change the redirects. At the moment, everybody is going to be sent to the new survey, but as Wil notes, that may not be right.

Comment 5

[ken kovash]

(In reply to comment #3)
> (From update of attachment 379677 [details] [diff] [review])
> If that does what you want it works for me, although the URL is
> firefox-specific now.  Also, isn't this conflicting with bug 485950?

I'm almost certain that we're not moving forward with bug 485950 (we're implementing a completely different project to address mrz's needs).  I've asked mrz to confirm on that bug.

Comment 6

[ken kovash]

(In reply to comment #2)
> Created an attachment (id=379677) [details]
> Patch, rev. 1
> 
> Wil: These htaccess changes to survey.mozilla.com forward people to the new
> uninstall page. To see how the new page looks/works, please refer to bug
> 489698.
> 
> Ken: I noticed that besides ua and application, there are two more, relevant
> GET variables (version and lang), which I also added to the ones being
> forwarded to surveymonkey. If that's not what we want, please speak up. (At any
> rate, they won't do any harm).

The more GET variables, the better.  btw, what's the difference between "ua" and "version"?  In comment #0, we have "ua=3.0.8".  Is "version" something different?

Comment 7

[ken kovash]

(In reply to comment #4)
> Ken: Did I misunderstand you, do I need to set up these redirects so that they
> only work when the client is Firefox? If survey.mozilla.org and your new survey
> are supposed to happily coexist, I need to change the redirects. At the moment,
> everybody is going to be sent to the new survey, but as Wil notes, that may not
> be right.

I'm not sure I totally understand.

Wil -- are you simply noting that we're just making changes to the Firefox uninstall survey and not the Thunderbird uninstall survey (that seems to be the other product listed at https://survey.mozilla.com)?

For this project, can't we just set-up redirects for all variations of the Firefox uninstall survey and just not touch anything related to Thunderbird?  For example, https://survey.mozilla.com/results/add/?application=firefox&ua=3.0.8 would redirect to some variation of https://www.mozilla.com/en-US/firefox/uninstall.

Comment 8

[Wil Clouser [:clouserw]]

Fred's patch redirects all "add" traffic on the surveys to moz.com/en-US/firefox/uninstall.  I was just asking if that's what you really wanted (it doesn't sound like it).

Comment 9

[Fred Wenzel [:wenzel]]

Comment on attachment 379677 [details] [diff] [review]
Patch, rev. 1

Okay, that was a misunderstanding then. I'll need to write rewrite rules that forward firefox and only that to the new page, yet leave the other surveys in place for all other products.

Comment 10

[Fred Wenzel [:wenzel]]

(In reply to comment #6)
> The more GET variables, the better.  btw, what's the difference between "ua"
> and "version"?  In comment #0, we have "ua=3.0.8".  Is "version" something
> different?

Who can we ask about the in-product links? I don't know what the difference is supposed to be, I just saw the variables used in the survey page code.

Comment 11

[ken kovash]

Rob -- could you help us with comment #6 and comment #10?

Comment 12

[Robert Strong (they/them - no direct email)]

The example urls in this bug don't include the step. Can someone provide an example full url the installer should launch and I'll create a patch for this. If you prefer I can make it so the url is read from the ini file as well... just let me know

Comment 13

[Fred Wenzel [:wenzel]]

Rob: I don't think we need to change the in-product links. I am fine with adding redirects on the server side (like we do with many in-product links). What you could shed some light on for us, though, is what the four GET variables (application, ua, version, lang) for the uninstall survey contain. Application and lang are quite obvious, yet version and ua we are unsure about.

Comment 14

[Robert Strong (they/them - no direct email)]

Sorry, I thought this was a change for the install survey.

The only thing I have visibility to is the url  that is launched which is
https://survey.mozilla.com/1/Mozilla%20Firefox/${AppVersion}/${AB_CD}/exit.html

Where ${AppVersion} is the version of the app and ${AB_CD} is the locale for the app that is being uninstalled.

Comment 15

[Fred Wenzel [:wenzel]]

Thanks, Rob, that helps. Ken: My crystal ball tells me, the "1" is meant to be a survey version (maybe), which we can ignore at the moment, followed by application, then what we called "ua", and finally the client locale.

I'll go ahead and change the redirects so that all (and only) Firefox users are forwarded to the new survey page, all other behavior will stay the same.

Comment 16

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 2

Wil: Does this look like it makes more sense?

Comment 17

[Wil Clouser [:clouserw]]

Comment on attachment 380410 [details] [diff] [review]
Patch, rev. 2

untested, but it looks fine

Comment 18

[ken kovash]

Can this be marked as resolved/fixed?  Can we push the redirects live (bug
496023)?

Comment 19

[Fred Wenzel [:wenzel]]

I just committed the rewrite rules to r27203.

Clouserw, do you know how survey.mozilla.com is pushed live? Do we have a production tag or anything fancy? Or does IT just svn up?