Closed Bug 489773 Opened 11 years ago Closed 11 years ago

Invitation dialog has flaws

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dbo, Assigned: martinschroeder)

Details

(Keywords: regression, Whiteboard: [not needed beta][no l10n impact])

Attachments

(1 file)

Get multiple invitations, then open the invitation dialog (press the link) in the footer bar: Selecting an invitation shows the accept/decline buttons, but the previous selection does not hide its buttons nor is the new selection hilighted.
Flags: blocking-calendar1.0?
Flags: blocking-calendar1.0? → blocking-calendar1.0+
Assignee: nobody → mschroeder
Status: NEW → ASSIGNED
Attached patch Patch v1Splinter Review
* Selection was missing because the used background image has been removed from toolkit. Replaced it with standard highlight color.
* Corrected color values for listbox items for better visibility.
* Replaced event handler for button handling with CSS solution.
* Corrected -moz-user-focus, so you can just tab the buttons and the selected listbox item.
Attachment #381367 - Flags: review?(dbo.moz)
Comment on attachment 381367 [details] [diff] [review]
Patch v1

> calendar-invitations-richlistbox {
>   -moz-binding: url(chrome://calendar/content/calendar-invitations-list.xml#calendar-invitations-richlistbox);
>-  -moz-user-focus: normal;
>+  -moz-user-focus: ignore;
> }
I think the default is -moz-user-focus: ignore. Please check this and remove the style accordingly.

> calendar-invitations-richlistitem[selected="true"] {
>-  background-image: url("chrome://mozapps/skin/downloads/downloadSelected.png") !important;

Try this instead:
background-image: url(chrome://mozapps/skin/extensions/itemEnabledFader.png);
Attachment #381367 - Flags: review?(dbo.moz) → review+
Whiteboard: [not needed beta][no l10n impact]
(In reply to comment #2)
> I think the default is -moz-user-focus: ignore. Please check this and remove
> the style accordingly.
Yep... removed twice!

> Try this instead:
> background-image: url(chrome://mozapps/skin/extensions/itemEnabledFader.png);
Works! :)

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/67ab9ddecfbe>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.