489835 - m_verifyAddress not used

Status: RESOLVED FIXED

(MailNews Core :: Networking: SMTP, defect)

Description

[David :Bienvenu]

m_verifyAddress is not used/set, so we never do a VRFY - I'm not sure if we want to rip out the code or figure out why m_verifyAddress used to get set...

Comment 1

[David :Bienvenu]

this is nsSmtpProtocol.cpp,h

Comment 2

[Phil Ringnalda (:philor)]

If you're going to figure out why it used to get set, you'll need to pull out your Netscape 4.x tree: it was added just like it is, with nothing setting it (to anything other than nsnull), and hasn't changed since (unless it was by something that landed and got backed out again between milestones, and didn't mention verify in the commit message).

Comment 3

[Ludovic Hirlimann [:Usul]]

Attachment: Patch removing the variable

Comment 4

[David :Bienvenu]

Comment on attachment 374303 [details] [diff] [review]
Patch removing the variable

that's an awfully big patch for such a simple change :-) could you attach just the mailnews/compose diffs?

Comment 5

[Ludovic Hirlimann [:Usul]]

Attachment: the patch limited to the files :-)

Sorry I thought HG worked like cvs and would only do the directory I was in. Proper patch.

Comment 6

[David :Bienvenu]

Comment on attachment 374305 [details] [diff] [review]
the patch limited to the files :-)

you can keep going, I think - SMTP_SEND_VRFY_RESPONSE isn't needed anymore, so it can be removed, along with the code that checks it.

Comment 7

[David :Bienvenu]

And SendVerifyResponse()

Comment 8

[Ludovic Hirlimann [:Usul]]

Attachment: more cleanups

here you go

Comment 9

[David :Bienvenu]

Comment on attachment 374340 [details] [diff] [review]
more cleanups

sadly, now the numbers after 5 are wrong :-( These are useful when reading smtp logs or debugging, so it would be good to have them be right.

r=bienvenu, with that fixed.

 SMTP_RESPONSE = 0,                                  // 0
 SMTP_START_CONNECT,                                 // 1
 SMTP_FINISH_CONNECT,                                // 2
 SMTP_SEND_HELO_RESPONSE,                            // 3
 SMTP_SEND_EHLO_RESPONSE,                            // 4
-SMTP_SEND_VRFY_RESPONSE,                            // 5
 SMTP_SEND_MAIL_RESPONSE,                            // 6
 SMTP_SEND_RCPT_RESPONSE,                            // 7
 SMTP_SEND_DATA_RESPONSE,                            // 8
 SMTP_SEND_POST_DATA,                                // 9
 SMTP_SEND_MESSAGE_RESPONSE,                         // 10
 SMTP_DONE,                                          // 11
 SMTP_ERROR_DONE,                                    // 12
 SMTP_FREE,                                          // 13

Comment 10

[Ludovic Hirlimann [:Usul]]

Attachment: fixing review coments

Who should I ask sr to ?

Comment 11

[David :Bienvenu]

Comment on attachment 374347 [details] [diff] [review]
fixing review coments

I'll do sr. I'll land this for you as well - I fixed some nits around the code you changed while I was in there...

Comment 12

[David :Bienvenu]

fix checked in, thx, Ludovic.