Open Bug 489885 Opened 11 years ago Updated 11 years ago

Exception thrown while changing into Private Browsing mode [PBS__onAfterPrivateBrowsingModeChange]

Categories

(Firefox :: Private Browsing, defect)

3.5 Branch
x86
macOS
defect
Not set

Tracking

()

People

(Reporter: marcia, Unassigned)

Details

Seen while running Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090423 Shiretoko/3.5b4pre

STR:
1. Had one window open and then switched to PB mode.
2. I switched into PB mode but I was still looking at the bug I was looking at in regular browsing mode. I then saw this in the console:

Error: Exception thrown while processing the private browsing mode change request: [Exception... "'[JavaScript Error: "this._windows[aWindow.__SSi] is undefined" {file: "file:///Users/marcia/Desktop/1.9.1Branch/Shiretoko.app/Contents/MacOS/components/nsSessionStore.js" line: 2233}]' when calling method: [nsISessionStore::setBrowserState]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Users/marcia/Desktop/1.9.1Branch/Shiretoko.app/Contents/MacOS/components/nsPrivateBrowsingService.js :: PBS__onAfterPrivateBrowsingModeChange :: line 192"  data: yes]
Source File: file:///Users/marcia/Desktop/1.9.1Branch/Shiretoko.app/Contents/MacOS/components/nsPrivateBrowsingService.js
Line: 330
(In reply to comment #0)
> Seen while running Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
> rv:1.9.1b4pre) Gecko/20090423 Shiretoko/3.5b4pre
> 
> STR:
> 1. Had one window open and then switched to PB mode.
> 2. I switched into PB mode but I was still looking at the bug I was looking at
> in regular browsing mode. I then saw this in the console:

Hmm, I'm not sure if I understand the STR correctly here.  Before step 1, were you already in private browsing mode?  Have you been able to reproduce this?  Did you do anything special before this happened?

CCing Simon to see if he has any idea about the problem here.
(In reply to comment #0)
> JavaScript Error: "this._windows[aWindow.__SSi] is undefined"

I suspect bug 488930. Need reliable StR, though.
Haven't been able to reproduce this yet. I was doing some different test scenarios in and out of PB. I went back to regular browsing mode and loaded a bugzilla bug. Then I switched in PB and I was still looking at the same bug I had seen in regular mode (in other words the switch did not really happen). That is when I viewed the Error Console and saw the exception.

Will keep an eye out of it as I run through regression tests on B4.
Marcia, now that bug 488930 has been fixed both on trunk and branch, can you please test this again to see if you can reproduce this problem any longer?
Unfortunately this is one of these bugs that was very difficult to reproduce. I am constantly monitoring the error console, so I will certainly comment if I see it again. I am wondering if it was possibly extension related.
Do you remember which extensions you had installed (and active) on the test profile that you were using when you saw this error message?
Also, before bug 488930 was fixed, did you see this error message other than when you first filed this bug?
I will go back and try to find the profile I was testing with when this happened. I suspect it was during either the last Full Functional or Basic Functional test run that I did.

Comment 0 was the only time that I saw this bug, and I have not seen it since during testing.
Now it is coming back to me - I may have seen it while using the Tree Style Tab extension. In fact, when going back to my testing profile with that extension installed, I get the error below when switching into PB:

Error: Exception thrown while processing the private browsing mode change request: [Exception... "'[JavaScript Error: "ds is undefined" {file: "chrome://treestyletab/content/treestyletabbrowser.js" line: 476}]' when calling method: [nsISessionStore::setBrowserState]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Users/marcia/Desktop/1.9.1Branch/Shiretoko.app/Contents/MacOS/components/nsPrivateBrowsingService.js :: PBS__onBeforePrivateBrowsingModeChange :: line 148"  data: yes]
Source File: file:///Users/marcia/Desktop/1.9.1Branch/Shiretoko.app/Contents/MacOS/components/nsPrivateBrowsingService.js
Line: 330
You need to log in before you can comment on or make changes to this bug.