489886 - please QA the main Firefox page (version for pre-3.5 Firefox users)

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[John Slater]

Hi all. We'll be breaking the main Firefox 3.5 page into 4 versions:

1. Firefox 3.5+ users /en-US/firefox/personal.html
2. Firefox 3 and less /en-US/firefox/upgrade.html
3. IE users /en-US/firefox/ie.html
4. Anyone else /en-US/firefox/firefox.html

This is the page for version #2: people using pre-3.5 versions of Firefox.

Thanks!

Comment 1

[krupa raj[:krupa]]

Attachment: slightly out of border

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8

In  /en-US/firefox/upgrade.html,the links "See the Awards" and "Learn Some New Secrets" are slightly out of the light blue boundary. see screenshot.

Comment 2

[krupa raj[:krupa]]

Firefox:3.0.8

JS error in Firebug-

Details:
document.getElementById("feature-productivity") is null
https://www-trunk.stage.mozilla.com/en-US/firefox/upgrade.html
Line 192

Comment 3

[krupa raj[:krupa]]

"Learn more about Firefox 3.5’s performance upgrades." link is a 404.

Comment 4

[Steven Garrity [:sgarrity]]

Layout issue from comment #1 fixed in r24785.

JS issue from comment #2 fixed in r24783.

The Performance page isn't ready yet, but I've checked in a placeholder page for it in r24784.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Steven: please align "Launch the Video" with "See the Awards", thanks!

Comment 6

[Steven Garrity [:sgarrity]]

(In reply to comment #5)
> Steven: please align "Launch the Video" with "See the Awards", thanks!

Done in r25105.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

is there documentation somewhere on how these pages will be used ? Where will the texting of the browser version happen? Will index.html be used as a version checking page now ? This has significant impact on the way we direct users and I would like to understand the potential impact on our localized landing pages as well as the users redirected to europe/china/japan sites. Thanks

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

https://www-trunk.stage.mozilla.com/en-US/img/tignish/firefox/feature-bg-performance.png

Don't do that please, this is a localization blocker

Comment 9

[John Slater]

(In reply to comment #7)
> is there documentation somewhere on how these pages will be used ? Where will
> the texting of the browser version happen? Will index.html be used as a version
> checking page now ? This has significant impact on the way we direct users and
> I would like to understand the potential impact on our localized landing pages
> as well as the users redirected to europe/china/japan sites. Thanks
Hi Pascal. What kind of documentation are you looking for specifically? We don't have anything written out yet, but I'm sure Steven and I could talk you through any issues.

For what it's worth, my recommendation is that you only localize the "everyone else" version of the page (#4 in my list in comment #0...also https://bugzilla.mozilla.org/show_bug.cgi?id=489884). That's the most general one and should work the best for l10n. I mentioned that in an email to you earlier, but sorry if I wasn't more clear.

(In reply to comment #8)
> https://www-trunk.stage.mozilla.com/en-US/img/tignish/firefox/feature-bg-performance.png
> Don't do that please, this is a localization blocker
We really need to have this graphic in there...removing it isn't really a viable option. However, what I think we can do (and I meant to mention this earlier, sorry) is rework it so the text is just HTML floating above the image. It's in our standard Georgia font so there's nothing fancy about it. Steven, that's doable, right?

It's also worth noting that the specific numbers in this graphic will change when we run the final tests, but the text around it won't. So if we can convert it to HTML text we should be in good shape.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

the problem is text in graphics, not the graphics itself, keep the graphics but have real text around, it's better for localization and accessibility. Otherwise I will have to create an image per locale with localized texts and it will take a lot of time.

Comment 11

[John Slater]

(In reply to comment #10)
> the problem is text in graphics, not the graphics itself, keep the graphics but
> have real text around, it's better for localization and accessibility.
> Otherwise I will have to create an image per locale with localized texts and it
> will take a lot of time.
Yep, I know. The solution I was trying (and possibly failing) to explain above was to take the text out of the graphics. In other words, show the basic graphic with the stopwatches as it is now, and then overlay HTML text above it...final result should be that it looks the same and is also much more l10n-friendly.

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

yes, that's the way to go :)

Comment 13

[Staś Małolepszy :stas]

(In reply to comment #9)

> We really need to have this graphic in there...removing it isn't really a
> viable option. However, what I think we can do (and I meant to mention this
> earlier, sorry) is rework it so the text is just HTML floating above the image.

Just a note, I'm not sure if that has been mentioned explicitly: I think it would be a good idea to make both the text above *and* below the image be in the HTML, not graphic. Different languages use different decimal delimiters, as well as have different rules on using the exclamation mark.

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

@stas, not mentionned explecitely but I am glad that you did :)

Comment 15

[Steven Garrity [:sgarrity]]

These changes to make l10n more feasible sound good to me. I'll work on them tomorrow (Friday) as it's already quite late here.

Comment 16

[Steven Garrity [:sgarrity]]

I've replaced the performance chart with a hybrid of HTML and images that should be more easily localized (r25214). Let me know if this works for you.

Comment 17

[John Slater]

(In reply to comment #16)
> I've replaced the performance chart with a hybrid of HTML and images that
> should be more easily localized (r25214). Let me know if this works for you.
Thanks Steven. Can you make this update on the other pages that use this image? (Features page, other versions of the Firefox download page)

Comment 18

[Steven Garrity [:sgarrity]]

(In reply to comment #17)
> Thanks Steven. Can you make this update on the other pages that use this image?
> (Features page, other versions of the Firefox download page)

The other product pages include the same file, so they are covered. I've updated the Features page in r25253.

Comment 19

[John Slater]

Hey guys. Just checking in here. Think we're closing to wrapping up this page?

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #19)
> Hey guys. Just checking in here. Think we're closing to wrapping up this page?

I think we can hand this off to the localization team.

Comment 21

[raymond [:retornam] (inactive)]

verified fixed on https://www-trunk.stage.mozilla.com/en-US/firefox/upgrade.html