Closed Bug 489927 Opened 11 years ago Closed 11 years ago

PluralForm getter can be simplified

Categories

(Firefox :: General, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 3.6a1

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #374397 - Flags: review?(gavin.sharp)
Comment on attachment 374397 [details] [diff] [review]
patch

Are you sure the import() in the getter triggers a call to the setter? I suppose it wouldn't work otherwise, I'm assuming you've tested it.
Attachment #374397 - Flags: review?(gavin.sharp) → review+
Yes, I've tested it. I wasn't 100% sure, but it only seems to make sense this way. The fact that the call comes from the getter shouldn't really make a difference, or at least I don't see how it could differ in a sane way.
http://hg.mozilla.org/mozilla-central/rev/9f4cd24db074
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
You need to log in before you can comment on or make changes to this bug.