TUnit, check: Some binary tests end up in xpcshell directory

VERIFIED INVALID

Status

Testing
XPCShell Harness
VERIFIED INVALID
9 years ago
9 years ago

People

(Reporter: sgautherie, Unassigned)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 years ago
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b5pre) Gecko/20090424 SeaMonkey/2.0b1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d77750c8a7b8
 +http://hg.mozilla.org/comm-central/rev/b7fd81f51c6e)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090417 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/9e06217fc471
 +http://hg.mozilla.org/comm-central/rev/...)

{
_tests\xpcshell\test_uriloader_exthandler\unit:
WriteArgument.exe

_tests\xpcshell\xpcom\unit:
a bunch of tests (though much less in 1.9.2 than in 1.9.1)
}

I guess they should rather end up in dist\bin?

Unless we would want to move all the binaries to a new _tests\check?
If they wind up there, it's intentional:
http://mxr.mozilla.org/mozilla-central/source/uriloader/exthandler/tests/Makefile.in#71
http://mxr.mozilla.org/mozilla-central/source/xpcom/tests/Makefile.in#157

the xpcshell tests rely on these binaries.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → INVALID
(Reporter)

Comment 2

9 years ago
(In reply to comment #1)
> the xpcshell tests rely on these binaries.

Oh, I didn't know there were such cases :-<

V.Invalid

*****

(In reply to comment #0)
> I guess they should rather end up in dist\bin?
> Unless we would want to move all the binaries to a new _tests\check?

What do you think about this for all the tests that are in dist\bin?
Status: RESOLVED → VERIFIED
It might be nice to make things that are CPP_UNIT_TESTS wind up in some directory other than dist/bin, although we'll then need some sort of wrapper to run them, as they all rely on things in dist/bin. In general, we might want that as a stepping stone to be able to run those tests on packaged builds.
(Reporter)

Comment 4

9 years ago
(In reply to comment #3)
> It might be nice to make things that are CPP_UNIT_TESTS wind up in some
> directory other than dist/bin

I filed bug 490223.
You need to log in before you can comment on or make changes to this bug.